feat(ui5-icon): change src property to name #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskelin
reviewed
Nov 15, 2019
packages/fiori/src/ShellBar.js
Outdated
| @@ -728,7 +728,7 @@ class ShellBar extends UI5Element { | |||
|
|
|||
| const items = [ | |||
| { | |||
| src: "sap-icon://search", | |||
| src: "search", | |||
There was a problem hiding this comment.
src now means icon, otherwise very confusing
packages/fiori/src/ShellBar.hbs
Outdated
| @@ -55,7 +55,7 @@ | |||
| data-ui5-notification-count="{{../notificationCount}}" | |||
| data-ui5-external-action-item-id="{{this.refItemid}}" | |||
| class="{{this.classes}}" | |||
| src="{{this.src}}" | |||
| name="{{this.src}}" | |||
There was a problem hiding this comment.
as below, a better option is name="{{this.icon}}"
pskelin
previously approved these changes
Nov 15, 2019
vladitasev
previously approved these changes
Nov 15, 2019
pskelin
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icons are no longer referenced by src, but rather just by name.
BREAKING CHANGE:
@ui5/webcomponents/dist/Icon.jsThe
srcproperty was renamed tonameand accepts icon name (such as "add") instead of icon src (such as "sap-icon://add").Note: the
srcproperty will continue to work until the next release due to the impact of the change, but will produce a warning in the console.@ui5/webcomponents/dist/Card.jsThe
avatarproperty was removed.Use the
avatarslot instead - pass an icon(<ui5-icon) or an image(<img).Example:
<ui5-card avatar="sap-icon://add"></ui5-card>becomes:
<ui5-card><ui5-icon name="add" slot="avatar"></ui5-icon></ui5-card>and respectively:
<ui5-card avatar="http://url/to/my/image"></ui5-card>becomes:
<ui5-card><img src="http://url/to/my/image" slot="avatar"/></ui5-card>@ui5/webcomponents-fiori/dist/ShellBarItem.jsThe
srcproperty was renamed toiconand accepts icon name (such as "add") instead of icon src (such as "sap-icon://add")