Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update dependencies and move to eslint #82

Merged
merged 14 commits into from
Sep 7, 2020
Merged

fix: update dependencies and move to eslint #82

merged 14 commits into from
Sep 7, 2020

Conversation

rayakoren
Copy link
Member

Before submitting a pull request, please ensure the following:

Description

Please explain the changes you made.

Add a link to the design (if applicable).

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

tal-sapan
tal-sapan suggested changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@tal-sapan tal-sapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

src/commands/addModuleCommand.ts Outdated Show resolved Hide resolved
src/commands/mtarDeployCommand.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/logger/settings-changes-handler.ts Outdated Show resolved Hide resolved
src/logger/logger-wrapper.ts Outdated Show resolved Hide resolved
tests/mockUtil.ts Outdated Show resolved Hide resolved
src/utils/selectionItem.ts Show resolved Hide resolved
tal-sapan
tal-sapan reviewed Sep 7, 2020
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
src/logger/logger-wrapper.ts Outdated Show resolved Hide resolved
@rayakoren rayakoren changed the title fix: update dependencies fix: update dependencies and move to eslint Sep 7, 2020
@rayakoren rayakoren merged commit 5478412 into master Sep 7, 2020
@rayakoren rayakoren deleted the ts_struct_fix branch September 7, 2020 14:37
@rayakoren rayakoren mentioned this pull request Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tal-sapan tal-sapan tal-sapan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rayakoren @tal-sapan