Preserve doctype nodes

[kddnewton]

Hi there!

I've started using the parser in prettier's XML plugin (https://github.com/prettier/plugin-xml). It's really great, thanks for this!

One thing - I can't get doctype nodes from the parser at all (presumably due to https://github.com/SAP/xml-tools/blob/master/packages/parser/lib/lexer.js#L58). I don't know chevrotain's API very well, but does it support adding configuration options or overrides such that I could get those kinds of nodes?

Thanks!

[bd82]

Thanks for reporting this @kddeisz 👍

I found the relevant grammar specification:

• https://www.w3.org/TR/xml/#NT-doctypedecl

And will attempt to implement it later today (hopefully).

[kddnewton]

@bd82 no worries take your time!

[bd82]

no worries take your time!

Hopefully it would not be a large time investment to fix this issue
and also I am interested in having a high quality XML plugin for prettier.

@marceloschreiber even started exploring implementing such a plugin in this repo.

• https://github.com/SAP/xml-tools/tree/master/packages/prettier-plugin-xml

However it is much preferred if it is developed as part of the prettier organization...
and contribute fixes/improvements there...

[kddnewton]

Oh nice - yeah very much open to PRs over at prettier/plugin-xml

[bd82]

5b4db21

[kddnewton]

Nice work!

On Mon, Jan 20, 2020 at 5:53 PM Shahar Soel ***@***.***> wrote: 5b4db21 <5b4db21> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#81?email_source=notifications&email_token=ABG3P3QVWXLOVTSO5AOL6CTQ6YTP7A5CNFSM4KI36762YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJN7XXY#issuecomment-576453599>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABG3P3SV6TYZYT26KDXIN5DQ6YTP7ANCNFSM4KI3676Q> .

-- *Kevin D. Deisz* CTO, CultureHQ <https://www.culturehq.com>

[bd82]

Try version 1.0.0 of the Parser.

• https://github.com/SAP/xml-tools/blob/master/packages/parser/CHANGELOG.md#100-2020-01-20

Note the DOCType may have a full DTD schema specified inline
e.g:

<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE greeting [
  <!ELEMENT greeting (#PCDATA)>
]>
<greeting>Hello, world!</greeting>

This is intentionally not supported at this time as it would add too much complexity.
However I think the external DTD schema reference, e.g:

<!DOCTYPE article PUBLIC "-//OASIS//DTD DocBook XML V4.5//EN"
                         "http://docbook.org/xml/4.5/docbookx.dtd">

is the scenario which is more common and important...

[kddnewton]

We can cross that bridge when we come to it. In the meantime I'll close this since it's definitely working for what it needs to do. Thanks so much!

[bd82]

You are welcome 😄