Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put security message into the Generator's tooltip #553

Merged
merged 5 commits into from
Apr 18, 2021
Merged

Conversation

ira-gordin-sap
Copy link
Contributor

@ira-gordin-sap ira-gordin-sap commented Apr 11, 2021

image
image

@@ -1,5 +1,5 @@
const selectGeneratorQuestionHint =
"Select the generator that best fits the type of application you want to develop";
"When you create a project using a template, you become the code owner and as such, you are responsible for any updates or fixes that must be performed for it. We recommend you follow the industry best practice to use automated vulnerability scanning in the CI/CD pipeline to avoid supply chain and other cyber-attacks.";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recommend you to follow the software security industry best practice, to use automated vulnerability scanning in the CI/CD pipeline to avoid supply chain attack and other cyber-attacks.";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove the first sentence or only to fix the second?


By default, VS Code auto-updates extensions as new versions become available as explained in https://code.visualstudio.com/docs/supporting/faq#_how-do-i-opt-out-of-vs-code-autoupdates.
In case the auto-update is disabled in your VS Code, you should care to update the extension manually to the latest version in order to avoid supply chain and other cyber-attacks.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case the auto-update is disabled in your VS Code, you should care to frequently update the extension manually to the latest version in order to avoid supply chain attack and other cyber-attacks.

Copy link

@Paolaufer Paolaufer Apr 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If auto-update is disabled in your VS Code, you should update the extension manually to the latest version frequently to avoid supply-chain attacks an other cyberattacks.

@@ -1,5 +1,5 @@
const selectGeneratorQuestionHint =
"Select the generator that best fits the type of application you want to develop";
"When you create a project using a template, you become the code owner and as such, you are responsible for any updates or fixes that must be performed for it. We recommend you follow the industry best practice to use automated vulnerability scanning in the CI/CD pipeline to avoid supply chain and other cyber-attacks.";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you create a project using a template, you become the code owner and, as such, you are responsible for any required updates or fixes. We recommend following the industry best practice to use automated vulnerability scanning in the CI/CD pipeline to avoid supply-chain and other cyberattacks.

@ira-gordin-sap ira-gordin-sap merged commit 41f90c9 into master Apr 18, 2021
@ira-gordin-sap ira-gordin-sap deleted the sec branch April 18, 2021 09:29
devinea added a commit to devinea/yeoman-ui that referenced this pull request May 6, 2021
…mprovements

* origin/master:
  fix: put security message into the Generator's tooltip (SAP#553)
  chore: bump copy-webpack-plugin from 6.4.1 to 8.1.1 in /packages/backend (SAP#555)
  refactor: require 'chalk' as const
  chore: bump @types/object-hash from 1.3.4 to 2.1.0 in /packages/backend (SAP#561)
  chore: bump webpack from 5.25.0 to 5.33.2 in /packages/backend (SAP#560)
  chore: bump string-replace-loader in /packages/backend (SAP#559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants