fix: workaround for chrome issue #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ira-gordin-sap
approved these changes
Apr 20, 2021
alex-gilin
requested changes
Apr 21, 2021
packages/frontend/src/App.vue
Outdated
| @@ -664,6 +666,13 @@ export default { | |||
| }, | |||
| mounted() { | |||
| this.init(); | |||
| const refreshId = setInterval(() => { | |||
There was a problem hiding this comment.
please add a 'TODO' comment to remove that stuff when a root cause will solved
| @@ -298,6 +299,15 @@ export default { | |||
| ]); | |||
| this.ready = true; | |||
| }, | |||
| mounted() { | |||
| const refreshId = setInterval(() => { | |||
There was a problem hiding this comment.
please add a 'TODO' comment to remove that stuff when a root cause will solved
alex-gilin
requested changes
Apr 21, 2021
packages/frontend/src/utils.js
Outdated
| @@ -0,0 +1,11 @@ | |||
| export default { | |||
| removeClass: (elementId, className, interval = 100) => { | |||
There was a problem hiding this comment.
Suggested change
| removeClass: (elementId, className, interval = 100) => { | |
| removeCssClassWhenRendered: (elementId, className, interval = 100) => { |
packages/frontend/src/App.vue
Outdated
| @@ -664,6 +667,7 @@ export default { | |||
| }, | |||
| mounted() { | |||
| this.init(); | |||
| utils.removeClass("workaround", "material-icons"); | |||
There was a problem hiding this comment.
please consider to add a 'TODO' comment to remove that stuff when root cause will solved
| @@ -298,6 +303,9 @@ export default { | |||
| ]); | |||
| this.ready = true; | |||
| }, | |||
| mounted() { | |||
| utils.removeClass("workaround-ex", "material-icons"); | |||
There was a problem hiding this comment.
please consider to add a 'TODO' comment to remove that stuff when root cause will solved
alex-gilin
approved these changes
Apr 21, 2021
devinea
added a commit
to devinea/yeoman-ui
that referenced
this pull request
May 6, 2021
…mprovements * origin/master: fix: input prompts are always showing loading icon (SAP#577) chore(release): release v1.2.4 chore: bump inquirer-gui from 0.1.27 to 0.2.0 (SAP#575) chore: bump @vscode-logging/logger in /packages/backend (SAP#562) chore: bump webpack-cli from 4.5.0 to 4.6.0 in /packages/backend (SAP#565) chore: bump @types/ws from 7.4.0 to 7.4.2 in /packages/backend (SAP#571) chore: change rootDirs test path (SAP#570) chore(release): release v1.2.3 fix: workaround for chrome issue (SAP#569) Revert "fix: workaround for chrome issue" fix: workaround for chrome issue # Conflicts: # packages/backend/package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.