Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata/review #117

Merged
merged 36 commits into from Aug 25, 2023
Merged

Metadata/review #117

merged 36 commits into from Aug 25, 2023

Conversation

maawoo
Copy link
Member

@maawoo maawoo commented Jul 10, 2023

  • Correctly set meta['prod']['RTCAlgorithm'] and meta['prod']['geoCorrAccuracy_rRMSE'] depending on condition, else they will be set to None (5932675, 7ae00eb)
  • Remove meta['prod']['file...'] entries. These are now handled by the xml and stac modules. (b6b27d1)
  • New entry for DEM Ground Sample Distance (GSD): meta['prod']['demGSD'] (4282d31)
    • XML: Always included as <s1-nrb:ProcessingInformation>/<s1-nrb:DEMGroundSamplingDistance> (4282d31)
    • STAC: Only included for asset with role 'digital-elevation-model' as RasterBand.spatial_resolution (b1f831c)
  • Rename variable tifs to assets in metadata parsing functions + general improvements in handling assets (ea4ba54)
  • XML: Include VRT assets (ea4ba54)
  • STAC: Use pystac.MediaType.XML for VRT assets (d66e134)
  • STAC: Change order of properties (1f4caad)
  • STAC: Require pystac >= 1.8.0 and implement new extensions:
    • pystac.extensions.mgrs.MgrsExtension (4c9219c)
    • pystac.extensions.file.FileExtension (c874e88)
    • pystac.extensions.raster.RasterExtension (42f217f)
    • pystac.extensions.classification.ClassificationExtension (bb63fdd)
  • STAC: New helper functions that bring some needed order to the generation of asset metadata in stac.product_json
  • Rename ITEM_MAP and SAMPLE_MAP in metadata.mapping (4fabc8f, af0e948)
  • Rename etree_from_sid and extract_pslr_islr in metadata.extract (db0cc98)
  • Reorganize modules (e.g., main function at the top):
  • metadata.extract: upstream fixes of invalid STAC fields (6fd639c)
  • STAC: fix title of noise-power assets (b82c475)
  • STAC/XML: fix created-datetime of assets (2886102, 640c40b)
  • STAC/XML: Exclude fields if None in METADATA-section of config file (cf87893)
  • Some other minor clean-ups, improvements and bug fixes

maawoo added 26 commits June 26, 2023 12:23
@maawoo maawoo marked this pull request as ready for review August 22, 2023 13:07
@maawoo
Copy link
Member Author

maawoo commented Aug 22, 2023

This PR has now grown enough and is ready to be merged soon in my opinion. @johntruckenbrodt how do you want to proceed and to which degree do you want (or rather have time) to review?

I have run some tests today and checked product and source metadata (for cases of 1 and 2 source files) and everything works smoothly on my end. I've also validated the STAC metadata as suggested by @jonas-eberle in #119. Excluding the card4l schema (not mature enough) and errors due to placeholder null hrefs, I've not encountered any issues.

Copy link
Member

@johntruckenbrodt johntruckenbrodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot @maawoo. This is quite a large and important piece of work. I won't go through all of it, you are much deeper into metadata than I am.

S1_NRB/metadata/extract.py Outdated Show resolved Hide resolved
environment.yaml Show resolved Hide resolved
@johntruckenbrodt johntruckenbrodt merged commit 5ee92bf into main Aug 25, 2023
1 check passed
@maawoo maawoo deleted the metadata/review branch August 25, 2023 12:15
@maawoo maawoo mentioned this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid dates in STAC metadata STAC Item-Assets: Differentiate between Noise Power assets in asset title
2 participants