Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for fetching boost #10

Closed
wants to merge 9 commits into from
Closed

Conversation

PritK99
Copy link
Contributor

@PritK99 PritK99 commented Feb 7, 2023

@SAtacker
Copy link
Owner

SAtacker commented Feb 7, 2023

@PritK99 you'll have to change the CI for all the platforms and remove boost installation.
Also rebase your branch on master and sign off your commits.

@SAtacker
Copy link
Owner

SAtacker commented Feb 7, 2023

Have a look in the .github folder and look for workflows.

CMakeLists.txt Outdated
include(FetchContent)
FetchContent_Declare(
Boost
GIT_REPOSITORY https://github.com/boostorg/boost.git
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enable only some part of boost for spirit instead of cloning all of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fetch only https://github.com/boostorg/spirit.git and https://github.com/boostorg/regex.git instead of fetching https://github.com/boostorg/boost.git as whole ?
The code builds in ubuntu if we just fetch boost for spirit and regex.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to fetch spirit only and please let me know?

@PritK99
Copy link
Contributor Author

PritK99 commented Feb 8, 2023

Added code to fetch boost spirit only instead boost as whole.
Please review.

@SAtacker
Copy link
Owner

SAtacker commented Feb 8, 2023

Added code to fetch boost spirit only instead boost as whole.
Please review.

Thanks, just two more things.

  1. Change the github CI workflow file. It has boost library installs using the package manager like vcpkg for windows and apt for linux. Just remove those lines in the workflow CI yaml file.
  2. Check out the issue Windows build failing  #9 (comment) that explains why the windows build fails. Please resolve that as well.

Signed-off-by: PritK99 <pritpjk@gmail.com>
@SAtacker
Copy link
Owner

Merged in #16

@SAtacker SAtacker closed this Feb 19, 2023
@PritK99 PritK99 deleted the prit_dev branch February 24, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants