e2e tests need to be reviewed

[McHaillet]

Larger functionality tests in the tests/E2ETests folder need to be reviewed and made functional again. We should also agree on running them ever so often (or before each commit to master).

So far I reviewed the e2e-test for:

• GLocal: updated with flcf score test on gpu
• TemplateMatching: this test is now a unit test for both cpu and gpu

[sroet]

For now most of the E2E tests are failing for me with:

TypeError: general_transform_crop: v must be of type pytom.lib.pytom_volume.vol! Got <class 'pytom_volume.vol'> instead!

Do you know if that is just a leftover due to the test files being saved with the old names, or is the class set wrong somewhere in the swig files?

[McHaillet]

I would not expect that error. I dont hink any class information is saved in the .em file format. So, when the .em particle files are read, I would expect them to be initialized as pytom.lib.pytom_volume.vol. Maybe something in swig then...

[sroet]

sorry for the noise, I had a leftover old install that interfered with my package resolving

[sroet]

However we should keep this in mind when people update to the new version, as that might interfere as well for them

[sroet]

Some more notes for me:
IMOD is a hard requirement for the E2E tests (everything past part 14 relies on it)

[McHaillet]

I think we reviewed all by now right?

To be sure, I will run python -m unittest discover from the e2etest directory when i get home