Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to pyproject.toml #104

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Feb 13, 2024

closes #6
I did update some of the other classifiers that are mentioned in https://pypi.org/classifiers/ and added vim swap files to the gitignore

@sroet sroet requested a review from McHaillet February 13, 2024 16:53
@sroet sroet changed the title Convert to pyproject toml Convert to pyproject.toml Feb 13, 2024
Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the update!

Should I also give the installation a test?

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Marten <58044494+McHaillet@users.noreply.github.com>
@sroet
Copy link
Collaborator Author

sroet commented Feb 14, 2024

Should I also give the installation a test?

Please do! also make sure you can install the [plotting] optional as well

Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, install works like a charm

@sroet sroet merged commit 5ec89f0 into SBC-Utrecht:main Feb 14, 2024
@sroet sroet deleted the convert_to_pyproject_toml branch February 14, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to .toml file for installation
2 participants