Cupy13 workaround #107
Merged
Cupy13 workaround #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroet
requested changes
Feb 14, 2024
Co-authored-by: Sander Roet <sanderroet@hotmail.com>
|
Yes, tested it with cupy 12.3 and cupy 13, both work 👍 |
sroet
added a commit
to sroet/pytom-template-matching-gpu
that referenced
this pull request
May 7, 2024
McHaillet
pushed a commit
that referenced
this pull request
May 7, 2024
* update cupy dependency version to exclude 13.0 * revert cupy workaround added in #107 * apperantly quotes around version numbers are not expected...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround for ReductionKernel bug in cupy 13. Code checks if cupy version 13 is installed and switch to simple
, instead of custom kernel.
See issue #106 for more info. The custom kernel is still preferred as it provides a ~2 x speed up.