Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coverage reporting #118

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Feb 21, 2024

This should add coverage and coverage reporting as a github action

@sroet
Copy link
Collaborator Author

sroet commented Feb 21, 2024

hmm this can't easily be done with github workflows, without external parties due to github security. (It does not allow any workflows that run on a PR from forks on public repos to have write access to anything, which is required to write a comment on the PR with the required info).

There is technically an example roundabout way of dealing with it: https://github.com/py-cov-action/python-coverage-comment-action which I could look into.

Otherwise, I can probably set it up with an external party:

@McHaillet which of the following would you prefer? (I slightly prefer to see if I can get the roundabout way to work)

@sroet
Copy link
Collaborator Author

sroet commented Feb 21, 2024

Hmm, I just realized that the codecov reporting code will probably not work as it pulls some data to figure out which PR to post stuff to, which is then run on a pipline that has no reference to that PR...

@sroet
Copy link
Collaborator Author

sroet commented Feb 21, 2024

alright, switched to another package that should work
@McHaillet please have a look (it will not work properly before coverage.yml is actually in the repo)

@sroet sroet requested a review from McHaillet February 21, 2024 20:14
@sroet sroet merged commit 2fd4588 into SBC-Utrecht:main Feb 22, 2024
1 check passed
@sroet sroet deleted the add_coverage_reporting branch February 22, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants