Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch unittest inconsistency #66

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Patch unittest inconsistency #66

merged 4 commits into from
Nov 17, 2023

Conversation

McHaillet
Copy link
Collaborator

Closes #58.

It works! 😌

  • Both the test_parallel_manager and test_tm_job_split_volume now only compare the score and angle volume with a distance of template_size // 2 from the edge as we expect numerical inaccuracies in those regions.
  • test_tm_job_split_volume now splits along each dimensions (2,3,2) creating 12 subvolumes
  • test_parallel_manager still only splits (1,3,1) as this test should just check the parallel managing part

@McHaillet McHaillet requested a review from sroet November 16, 2023 16:24
@sroet sroet marked this pull request as ready for review November 16, 2023 16:28
@McHaillet
Copy link
Collaborator Author

Added a test that checks whether split volume raises the correct error with too small pieces

sroet
sroet requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small readability improvement, LGTM othewise

tests/test_tmjob.py Outdated Show resolved Hide resolved
tests/test_tmjob.py Outdated Show resolved Hide resolved
@McHaillet @sroet
readability improvement for slices edges of score maps in the tests
ccc0736 
Co-authored-by: Sander Roet <sanderroet@hotmail.com>
@McHaillet
Copy link
Collaborator Author

Added your suggestions and checked that the tests still succeed!

sroet
sroet approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge

@McHaillet McHaillet requested a review from sroet November 17, 2023 09:48
@McHaillet McHaillet merged commit 07ff2c0 into SBC-Utrecht:main Nov 17, 2023
@McHaillet McHaillet deleted the patch-unittest-inconsistency branch November 17, 2023 09:48
@chris-hypercag chris-hypercag mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroet sroet Awaiting requested review from sroet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error message of the unittests
2 participants
@McHaillet @sroet