Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make json writing OS agnostic in tmjob.py #90

Merged
merged 1 commit into from
Feb 7, 2024
Merged

make json writing OS agnostic in tmjob.py #90

merged 1 commit into from
Feb 7, 2024

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented Feb 6, 2024 •
edited

I greped through the codebase and this was the only instance of PosixPath that came back.
This is untestable as pathlib.WindowsPath('.') will error out with a NotImplementedError on unix systems

closes #89

@sroet sroet requested a review from McHaillet February 6, 2024 17:10
@sroet
Copy link
Collaborator Author

sroet commented Feb 6, 2024

tests still pass 😄

McHaillet
McHaillet approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@McHaillet McHaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix :)

@sroet sroet merged commit bc1fced into main Feb 7, 2024
@sroet sroet deleted the sroet-patch-1 branch February 7, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McHaillet McHaillet McHaillet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make json dumping OS agnostic
2 participants
@sroet @McHaillet