Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuMI XSec 2024 Updated Production Patch: Gray's update to angular dependence of recombination #687

Open
brucehoward-physics opened this issue Feb 15, 2024 · 5 comments · Fixed by #694

Comments

@brucehoward-physics
Copy link
Contributor

No description provided.

@brucehoward-physics
Copy link
Contributor Author

This change brings with it needs to icaruscode and larreco (as it's handled in a calibration for the data)

Two ways this might be handled:

  1. Gray has a larreco feature branch (feature/gputnam-angcalo)
  2. These commits or something like them were merged into develop larreco (fc790c0f80d4fc90d892abe467be4084835e2d6e and 3f7b79423dab53b75bce8f42ff149cb3afe092c9) and so a nice way might be to have a tag made by larsoft if possible with these included.

@brucehoward-physics
Copy link
Contributor Author

Partly covered in #694 BUT still need the larreco changes.

@SFBayLaser
Copy link
Contributor

I don't think the LArSoft people can do anything with larreco until there is a pull request. They have a procedure that they will then follow to make the needed release.

@brucehoward-physics
Copy link
Contributor Author

LArSoft/larreco#63 and email communication with scisoft underway

@brucehoward-physics
Copy link
Contributor Author

Updating on status: We met with @miquelnebot and @ibsafa this morning and I think they will be able to follow the LArSoft needs to make the tag, but we need to give them some more info about if there are other LArSoft branches we'll touch. Will work on deciding/following up on this today 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants