Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/howard larreco to use gptunam changes #63

Conversation

brucehoward-physics
Copy link

@brucehoward-physics brucehoward-physics commented Feb 27, 2024

Hi - This is actually not meant to be a PR against develop but I can't make a PR against a tag (v09_17_06 is what I'm after).

Some ICARUS analyzers (myself included) would like to make an updated version of an older release useful for reprocessing reconstruction and calibration for some ongoing analyses. One of these changes is to introduce the angular dependence introduced by Gray Putnam in larreco commits already merged to develop, we just want these to be available in our version. The feature branch on my fork is meant to be tag: v09_17_06, tag: LARSOFT_SUITE_v09_72_00 with Gray's commits added)

Starting a PR here to get that conversation going and will point some of the relevant SBN/ICARUS release managers/software coordinators here.

(And please let me know if there is a better way to make it go against a proper working area!)

@lgarren
Copy link
Member

lgarren commented Feb 27, 2024

A couple of comments here.
First, you cannot update just larreco without also updating larrecodnn, larana, and larsoft. It's a dependency tree issue.
Second, when the dust settles, you will be wanting a production release based on a branch. The SciSoft team will base that branch on the relevant larsoft release that includes larreco v09_17_06.
For a production release, we will make the branches and hand control to the ICARUS software manager(s).
I suggest that we setup a meeting to discuss particulars (send email to scisoft-team@fnal.gov).

@FNALbuild
Copy link
Contributor

A new Pull Request was created by @brucehoward-physics (Bruce Howard) for develop.

It involves the following packages:

larreco

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@lgarren
Copy link
Member

lgarren commented Mar 11, 2024

@lgarren
Copy link
Member

lgarren commented Mar 11, 2024

The SciSoft team met with interested parties last week. We agreed to provide an initial patch release per our patch release procedures. Going forward, a support person needs to be identified who can be given privileges to make new releases when needed.

@lgarren
Copy link
Member

lgarren commented Mar 11, 2024

Closing this PR. It is merged with branch v09_72_00_br

@lgarren lgarren closed this Mar 11, 2024
@lgarren lgarren moved this from Under discussion to Approved and pending inclusion in release in LArSoft pull requests Mar 11, 2024
@lgarren lgarren moved this from Approved and pending inclusion in release to Included in release in LArSoft pull requests Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
LArSoft pull requests
  
Included in release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants