-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing vector line for SRPFPs to classes def #88
Conversation
This is definitely right, thanks for the catch Henry. |
@rhowell42 , could you formally approved this as a reviewer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sorry, looks good and approved
trigger build |
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_65_01 |
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
❌ CI build for SBND Failed at phase unit_test SBND on slf7 for c7:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test SBND phase logs parent CI build details are available through the CI dashboard |
❌ CI build for SBND Failed at phase unit_test SBND on slf7 for e20:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test SBND phase logs parent CI build details are available through the CI dashboard |
trigger build SBNSoftware/icarusalg#63 SBNSoftware/icaruscode#496 |
@miquelnebot this will also need the sbncode release/v09_65_03 branch to avoid the nusystematics problem. It may be that that branch needs pointing at this v09_20_02 version number as well so I won't trigger it myself. |
trigger build SBNSoftware/sbncode@release/v09_65_03 SBNSoftware/icarusalg#63 SBNSoftware/icaruscode#496 |
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
Found whilst pursuing a separate issue with the caf stage in the CI.
We now have vectors of SRPFPs, which we didn't used to. This requires a vector line in the classes def file. This seemed to cause intermittent issues when saving / opening caf files.