Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing vector line for SRPFPs to classes def #88

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

henrylay97
Copy link
Member

Found whilst pursuing a separate issue with the caf stage in the CI.

We now have vectors of SRPFPs, which we didn't used to. This requires a vector line in the classes def file. This seemed to cause intermittent issues when saving / opening caf files.

@rhowell42
Copy link
Contributor

This is definitely right, thanks for the catch Henry.

@cerati
Copy link

cerati commented Jan 13, 2023

@rhowell42 , could you formally approved this as a reviewer?

Copy link
Contributor

@rhowell42 rhowell42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sorry, looks good and approved

@miquelnebot
Copy link
Contributor

trigger build

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 23, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 23, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 23, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 23, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 23, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 23, 2023
@miquelnebot
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_65_01

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase unit_test SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase unit_test SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard

@miquelnebot miquelnebot changed the base branch from develop to release/v09_20_02 January 25, 2023 12:06
@miquelnebot
Copy link
Contributor

@henrylay97
Copy link
Member Author

@miquelnebot this will also need the sbncode release/v09_65_03 branch to avoid the nusystematics problem.

It may be that that branch needs pointing at this v09_20_02 version number as well so I won't trigger it myself.

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 25, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 25, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 25, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 25, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 25, 2023
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Jan 25, 2023
@miquelnebot
Copy link
Contributor

trigger build SBNSoftware/sbncode@release/v09_65_03 SBNSoftware/icarusalg#63 SBNSoftware/icaruscode#496

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot miquelnebot merged commit c5d8ff2 into release/v09_20_02 Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants