Accommodate breaking changes in geometry #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chilge
approved these changes
Dec 16, 2022
|
With this PR |
|
@ikatza, yes, LArSoft v09_65_00 is required for this PR. |
|
@ikatza sorry for the delay and jumping the gun on the merge. I just reverted it and updated the deps on sbndcode/icaruscode to v09_64_01. will remerge the PR when the next release of of sbndcode/icaruscode is available. |
chilge
added a commit
that referenced
this pull request
Mar 29, 2023
…terface" as this requires larsoft v09_65_00, not yet availavble in sbndcode/icaruscode" This reverts commit cfc3229. Requisite changes now made in sbnd/icaruscode.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to LArSoft/larcorealg#34.