Add in tau-coupled HNL mode to MeVPrtl generator #307

gputnam · 2022-10-20T18:37:24Z

A number of changes to enable more HNL production / final states. Depends on SBNSoftware/sbnobj#71 and SBNSoftware/sbnanaobj#83.

…o load meson fluxes from text file. Change KaonParent -> MesonParent to clarify that parent particles need not be kaons. Fix bugs in computation of 2l1v HNL decay. Add in more width computations to HNL for all accessible final states for M <~ 1GeV. Add in more options to ray-tracing to only rotate phi but not theta.

VCLanNguyen · 2022-11-18T14:27:19Z

MeVPrtlTruth class needs to be updated to include variables: total_mean_distance and allowed_decay_fraction for the sbncode PR#307

gputnam · 2022-11-18T15:12:14Z

Thanks @VCLanNguyen! I think I had forgot a commit to sbnobj -- just pushed it.

miquelnebot · 2022-11-18T17:08:14Z

@gputnam
Could you fix the conflicts? is only a change to cet_build_plugin format but if you could test your new TxtFileGen and tau2HNLflux additions would be great.
Also, please trigger CI when conflicts fixed.
I'll chase reviews
Thanks

gputnam · 2022-11-29T21:15:31Z

@miquelnebot I've fixed the merge errors.

miquelnebot · 2022-11-29T22:43:56Z

trigger build SBNSoftware/sbnobj#71 SBNSoftware/sbnanaobj#83

FNALbuild · 2022-11-29T22:47:12Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2022-11-29T22:47:20Z

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

FNALbuild · 2022-11-29T22:53:54Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2022-11-29T22:54:03Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2022-11-29T22:54:07Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2022-11-29T22:54:55Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

gputnam · 2022-11-29T23:29:12Z

@miquelnebot the build error is due to a header file that can't be found, which is confusing to me since the header file in question still seems to exist and is not newly included in this PR. Do you know what could be going on?

gputnam · 2022-12-01T19:49:01Z

I've fixed the build errors -- can we try again?

gputnam · 2023-01-05T18:31:54Z

@miquelnebot can we get this PR merged?

miquelnebot · 2023-01-14T17:39:21Z

@miquelnebot can we get this PR merged?

Currently software release being held for the geometry updates.Will do that ASAP

VCLanNguyen · 2023-01-17T03:44:24Z

sbncode/EventGenerator/MeVPrtl/config/numi_kaon_common.fcl

@@ -38,10 +60,10 @@ rethrow_ray_trace_box: {

  # weight computation
  #ReferenceLabSolidAngle: 1.6e-6 # approx solid angle of ICARUS @NuMI target
-  #ReferenceKaonEnergy: 15 # GeV
+  #ReferencePriamryEnergy: 15 # GeV


@gputnam typo

miquelnebot · 2023-01-23T14:50:29Z

trigger build SBNSoftware/sbnobj#71 SBNSoftware/sbnanaobj#83

miquelnebot · 2023-01-23T16:23:42Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_65_01 SBNSoftware/sbnobj#71 SBNSoftware/sbnanaobj#83

gputnam · 2023-01-23T20:49:14Z

@miquelnebot the build issue seems to be a dependency error which I don't think is related to this PR.

miquelnebot · 2023-01-24T14:33:19Z

@gputnam I know, we have a mismatch since the geometry changes before Christmas, which caused a few issues with being able to run the CI. We are about to resolve it and have this - and others- merged.
Thanks for your patience and understanding.

miquelnebot · 2023-01-25T11:54:10Z

trigger build SBNSoftware/sbnobj#71 SBNSoftware/sbnanaobj#83 SBNSoftware/icarusalg#63 SBNSoftware/icaruscode#496

FNALbuild · 2023-01-25T11:57:26Z

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

FNALbuild · 2023-01-25T11:57:29Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2023-01-25T12:35:48Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2023-01-25T12:45:01Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2023-01-25T12:51:59Z

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2023-01-25T13:08:55Z

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

miquelnebot · 2023-01-25T16:09:54Z

@mroda88 @jicrespo could one of you add the second review, please?
also, for the related PRs

mroda88

I didn't look all the details, but I haven't see anything obviously wrong. I made some comments. I think it would be best to have a chat about the physics we need to implement though, otherwise it's hard to tell if the code makes sense.

mroda88 · 2023-01-25T16:29:20Z

sbncode/EventGenerator/MeVPrtl/config/numi_kaon_common.fcl

@@ -25,6 +25,28 @@ numi_kaon: {
  RandomizeFiles: true
 }

+numi_tau: {
+  tool_type: TxtFileGen
+  SearchPath: "/pnfs/icarus/persistent/users/gputnam/numi_unconventional_fluxes/"


Can we have examples of fluxes in the PR itself? I don't like that the PR points to a personal user space

mroda88 · 2023-01-25T16:29:33Z

sbncode/EventGenerator/MeVPrtl/config/numi_kaon_common.fcl

+
+numi_eta: {
+  tool_type: TxtFileGen
+  SearchPath: "/pnfs/icarus/persistent/users/gputnam/numi_unconventional_fluxes/"


mroda88 · 2023-01-25T16:31:13Z

sbncode/EventGenerator/MeVPrtl/config/HNL/hnl.fcl


 mixedweight_ray_trace_box_kdar: @local::mixedweight_ray_trace_box
-mixedweight_ray_trace_box_kdar.ReferenceKaonEnergy: 0.494
+mixedweight_ray_trace_box_kdar.ReferencePriamryEnergy: 0.493677


typo here too

mroda88 · 2023-01-25T16:40:09Z

sbncode/EventGenerator/MeVPrtl/Tools/HNL/HNLMakeDecay_tool.cc

@@ -181,7 +250,7 @@ HNLMakeDecay::ThreebodyMomentum HNLMakeDecay::isotropic_threebody_momentum(doubl

  // The azimuthal angle of B and C about A is distributed uniformly
  double gammaB = (2*GetRandom() - 1.) * M_PI;
-  double gammaC = -gammaB;
+  double gammaC = fmod(gammaB + 2*M_PI, 2*M_PI) - M_PI;


Is this a physic change? Would it destroy backward compatibility? Do we care if it does?

It is a physics change, it's fixing a bug.

As far as backwards compatibility, I don't think I've shown results before with 3-body decays. When I tried to for the results in this PR, I found the bug. The simulation makes unphysical results otherwise.

miquelnebot · 2023-01-25T16:50:33Z

I didn't look all the details, but I haven't see anything obviously wrong. I made some comments. I think it would be best to have a chat about the physics we need to implement though, otherwise it's hard to tell if the code makes sense.

This was, as always, supposed to be discussed within the WG before approval and any reference posted here. If that's not the case I would refer to aprove it yet.

jicrespo · 2023-01-25T18:22:24Z

The physics was presented in an SBND BSM meeting, slides at https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=28395

The changes apply to ICARUS-NuMI physics since SBND is not doing any NuMI physics. For SBND, we just need to confirm it does not break our BNB work.

jicrespo · 2023-01-25T19:20:02Z

sbncode/EventGenerator/MeVPrtl/MeVPrtlTestRayTrace_module.cc

@@ -118,8 +118,8 @@ void evgen::ldm::MeVPrtlTestRayTrace::analyze(const art::Event& evt)
  while (1) {
    simb::MCFlux kaon = fGenTool->GetNext();

-    evgen::ldm::KaonParent kaonp(kaon);
-    bool is_kaon = kaonp.kaon_pdg != 0;
+    evgen::ldm::MesonParent kaonp(kaon);


The code is fine, but for consistency the objects and variable names and the message would be better changed to the generic "meson" instead of "kaon".

jicrespo · 2023-01-25T19:33:29Z

sbncode/EventGenerator/MeVPrtl/Tools/Constants.cpp

+  feta = 1.2*fpion;
+  fetap = -0.45*fpion;
+  grho = 0.102; // [GeV^2]


Add reference.

gputnam requested review from jicrespo, mroda88 and VCLanNguyen October 20, 2022 18:37

gputnam added 4 commits October 20, 2022 13:47

Fix weight computation.

4c15812

Clarify partial v. total width distinction.

c4f972e

Add in more / new vars to CAFMaker.

b31526a

Add in jupyter notebook to generate meson fluxes.

e7a9c34

Update tools to new build interface.

7fc796f

Update Tau2HNL to new build command.

1dea3b4

VCLanNguyen approved these changes Jan 13, 2023

View reviewed changes

VCLanNguyen reviewed Jan 17, 2023

View reviewed changes

bugfix in width computation

547557a

SBNSoftware deleted a comment from FNALbuild Jan 23, 2023

SBNSoftware deleted a comment from FNALbuild Jan 24, 2023

miquelnebot changed the base branch from develop to release/v09_65_03 January 25, 2023 11:48

Merge branch 'release/v09_65_03' into feature/gputnam-mevprtl-morehnl

4ac0c82

mroda88 reviewed Jan 25, 2023

View reviewed changes

miquelnebot deleted the branch release/v09_65_03 January 25, 2023 17:45

miquelnebot closed this Jan 25, 2023

jicrespo reviewed Jan 25, 2023

View reviewed changes

gputnam mentioned this pull request Jan 27, 2023

Feature/gputnam mevprtl morehnl #332

Merged

Add in tau-coupled HNL mode to MeVPrtl generator #307

Add in tau-coupled HNL mode to MeVPrtl generator #307

Conversation

gputnam commented Oct 20, 2022 • edited

VCLanNguyen commented Nov 18, 2022 • edited

gputnam commented Nov 18, 2022

miquelnebot commented Nov 18, 2022

gputnam commented Nov 29, 2022

miquelnebot commented Nov 29, 2022

FNALbuild commented Nov 29, 2022

FNALbuild commented Nov 29, 2022

FNALbuild commented Nov 29, 2022

FNALbuild commented Nov 29, 2022

FNALbuild commented Nov 29, 2022

FNALbuild commented Nov 29, 2022

gputnam commented Nov 29, 2022

gputnam commented Dec 1, 2022

gputnam commented Jan 5, 2023

miquelnebot commented Jan 14, 2023

VCLanNguyen Jan 17, 2023

Choose a reason for hiding this comment

miquelnebot commented Jan 23, 2023

miquelnebot commented Jan 23, 2023

gputnam commented Jan 23, 2023

miquelnebot commented Jan 24, 2023

miquelnebot commented Jan 25, 2023

FNALbuild commented Jan 25, 2023

FNALbuild commented Jan 25, 2023

FNALbuild commented Jan 25, 2023

FNALbuild commented Jan 25, 2023

FNALbuild commented Jan 25, 2023

FNALbuild commented Jan 25, 2023

miquelnebot commented Jan 25, 2023 • edited

mroda88 left a comment

Choose a reason for hiding this comment

mroda88 Jan 25, 2023

Choose a reason for hiding this comment

mroda88 Jan 25, 2023

Choose a reason for hiding this comment

mroda88 Jan 25, 2023

Choose a reason for hiding this comment

mroda88 Jan 25, 2023

Choose a reason for hiding this comment

gputnam Jan 27, 2023

Choose a reason for hiding this comment

miquelnebot commented Jan 25, 2023 • edited

jicrespo commented Jan 25, 2023

jicrespo Jan 25, 2023 • edited

Choose a reason for hiding this comment

jicrespo Jan 25, 2023

Choose a reason for hiding this comment

gputnam commented Oct 20, 2022 •

edited

VCLanNguyen commented Nov 18, 2022 •

edited

miquelnebot commented Jan 25, 2023 •

edited

miquelnebot commented Jan 25, 2023 •

edited

jicrespo Jan 25, 2023 •

edited