Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BNB Kaon Gen for SBND + Time of Flight Implementation #324

Merged
merged 11 commits into from
Jan 25, 2023
Merged

BNB Kaon Gen for SBND + Time of Flight Implementation #324

merged 11 commits into from
Jan 25, 2023

Conversation

VCLanNguyen
Copy link
Contributor

BNB Kaon Gen for SBND + Time of Flight Implementation for MeVPrtl

@VCLanNguyen
Copy link
Contributor Author

Remake the PR since I broke the other branch on the PR. Already addressed comments by Gray on the other PR (#317)

As in the names: this includes Gen modules for BNB Kaon and Time of Flight.

@rodralva
Copy link

Looks good to me!

rodralva
rodralva approved these changes Dec 16, 2022
View reviewed changes
Copy link

@rodralva rodralva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally BNB data support +ToF added to develop

@miquelnebot
Copy link
Contributor

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot
Copy link
Contributor

Hi @VCLanNguyen, CI tests failed, could you take a look?

@VCLanNguyen
Copy link
Contributor Author

Build errors seems to do with caf test, which this PR isn't related too. I'll start another build to check if the caf issue is resolved.

  ◼ nucosmics_caf_quick_test_sbndcode (Problem: Error in data production *** Scaled cpu usage 9345.181630000001 not in 3000.0:5000.0 range *** Memory usage 5244540.0 not in 2000000.0:4000000.0 range)

@VCLanNguyen
Copy link
Contributor Author

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@VCLanNguyen
Copy link
Contributor Author

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@VCLanNguyen
Copy link
Contributor Author

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_64_01

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@sjgardiner sjgardiner self-assigned this Jan 13, 2023
@miquelnebot
Copy link
Contributor

@gputnam @jicrespo @sjgardiner could any of you add the second review, please?

gputnam
gputnam approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@gputnam gputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@miquelnebot miquelnebot changed the base branch from develop to release/v09_65_03 January 25, 2023 12:03
@miquelnebot
Copy link
Contributor

trigger build SBNSoftware/icarusalg#63 SBNSoftware/icaruscode#496

@miquelnebot miquelnebot merged commit d5f6993 into release/v09_65_03 Jan 25, 2023
@LuisPelegrina LuisPelegrina mentioned this pull request Mar 15, 2023
Merged
@LuisPelegrina LuisPelegrina mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gputnam gputnam gputnam approved these changes

@rodralva rodralva rodralva approved these changes

@jicrespo jicrespo Awaiting requested review from jicrespo

@sjgardiner sjgardiner Awaiting requested review from sjgardiner

Assignees

@sjgardiner sjgardiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@VCLanNguyen @rodralva @miquelnebot @FNALbuild @gputnam @sjgardiner