Migration to the Refactored LArG4 #134

marcodeltutto · 2021-08-04T18:43:52Z

This PR contains all the necessary fcls and code to migrate to the new LArG4.
Changes are presented on docdb 22944.

Note that with this PR, the standard_g4_sbnd.fcl will run the new LArG4. To run the legacy larg4, fcl legacy_g4_sbnd.fcl should be used. All the g4_*.fcl files run the new LArG4. To run the legacy LArG4, replace g4_*.fcl with legacy_g4_*.fcl.
All the legacy g4 fcl files are in JobConfigurations/standard/g4/legacy/*

A new folder called LArG4 is added. This contains all the g4-related fcl configuration, as well as the physics list to be used in LArG4/PhysicsLists/. In this LArG4 folder:

larg4_sbnd.fcl: Configuration of the LArG4 module
larg4_services_sbnd.fcl: Configurations needed for the new LArG4
ionandscint_sbnd.fcl: Configuration for the ionization and scintillation part
simdrift_sbnd.fcl: Configuration for the electron drifting module
mcreco_sbnd.fcl: Configuration for MC reconstruction
PhysicsListLoader: a dummy module to load the physics list, needed before running LArG4

To run with the optical hybrid mode, fcl file g4_ophybrid_sbnd.fcl can be used in place of standard_g4_sbnd.fcl.

Open Items

Use correlated light model? -> Yes, as PR Adding QL-correlated G4 script #127 was merged.
Use optical hybrid mode? -> Added to default g4 workflow.
CRT part. -> Waiting for PR to be opened.

FHICL files

Suggested reviewer: @jzennamo
Standard fcls now run the new larg4. All the legacy fcls are in sbndcode/JobConfigurations/standard/g4/legacy/, and similar for detsim.

Optical

Suggested reviewer: @ggamezdiego

sbndcode/JobConfigurations/standard/standard_g4_sbnd.fcl: Runs in optical hybrid mode by default.
sbndcode/LArSoftConfigurations/photpropservices_sbnd.fcl: Adds optical library for light outside the active volume.
sbndcode/LArSoftConfigurations/PDFastSim_sbnd.fcl: Configuration for semi-analytical and optical library.
sbndcode/LArG4/larg4_services_sbnd.fcl: Specifies the LArG4 detector to use for the optical hybrid mode.
sbndcode/JobConfigurations/standard/g4/g4_noophybrid_sbnd.fcl: Same as standard_g4_sbnd.fcl, but without the optical hybrid part.

CRT

CRT will be included next. Right now, this PR excludes the CRT from the detsim stage. Issue #143 has been opened to track this.

Known Issues

All the MCParticles are saved, not only the ones in the cryostat and CRT. LArSoft issue 26106. For now, I produced GENIE+cosmic files and verified that the file size, although larger with the new LArG4, is still manageable.
There are many warning messages from SimDriftElectrons of type [...] unable to drift electrons from point [...] when electrons are drifted from points outside the active volume. LArSoft issue 26107.
The g4_simphotontime_filter.fcl will have to be reviewed to make sure the in-time and out-time paths are both running correctly. Issue Check Gen and G4 InTime FHiCLs with Refactored LArG4 #147 was opened to keep track of this issue.

Renames the current standard_g4_sbnd.fcl to legacy_g4_sbnd.fcl, as well as the simulationservices_sbnd.fcl and largeantmodules_sbnd.fcl.

Renames the current standard_detsim_sbnd.fcl to legacy_detsim_sbnd.fcl, and adds legacy configurations to detsimmodules_sbnd.fcl and opdetdigitizer_sbnd.fcl.

fcls added: - standard_g4_sbnd.fcl: Standard G4 fcl that now runs the refactored larg4 - standard_detsim_sbnd.fcl: Standard detsim fcl compatible with the standard_g4_sbnd.fcl above - larg4_sbnd.fcl: Configuration fcl for the new larg4 - larg4_services_sbnd.fcl: Services configuration for the new larg4 - ionandscint_sbnd.fcl: Configuration fcl for the IonizationAndScintillation module - simdrift_sbnd.fcl: Configuration fcl for the electron drift simulation module - simulationservices_sbnd.fcl: Updated simulation services for the new larg4

…cint:priorSCE

- Add a legacy folder inside the g4 one to store all the legacy g4 files - Move legacy_detsim_sbnd.fcl and legacy_g4_sbnd.fcl to the legacy/ folder - Create a legacy/others/ folder for all the others g4 legacy fcls

…volPDSstructure, and volTPCPlaneVert

This directory contains: - PhysicsLists/: which contains physics lists for SBND - PhysListLoader_module.cc: a dummy module to load physics lists - ionandscint_sbnd.fcl, larg4_sbnd.fcl, larg4_services_sbnd.fcl, legacy_largeantmodules_sbnd.fcl, legacy_simulationservices_sbnd.fcl, mcreco_sbnd.fcl, simdrift_sbnd.fcl: configuration fcl files

jzennamo

I just had two little questions, otherwise I approve this!

sbndcode/Geometry/gdml/sbnd_v02_00_base.gdml

sbndcode/JobConfigurations/standard/standard_detsim_sbnd.fcl

pgreen135 · 2021-08-16T13:45:25Z

trigger build

FNALbuild · 2021-08-16T13:46:11Z

CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard

FNALbuild · 2021-08-16T13:46:11Z

CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard

FNALbuild · 2021-08-16T13:47:03Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2021-08-16T13:47:04Z

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

FNALbuild · 2021-08-16T13:47:22Z

CI build for SBND on slf7 for e20:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

FNALbuild · 2021-08-16T13:47:22Z

CI build for SBND on slf7 for c7:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

FNALbuild · 2021-08-16T14:08:08Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2021-08-16T14:12:02Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

pgreen135 · 2021-08-16T17:24:10Z

trigger build

FNALbuild · 2021-08-16T17:24:53Z

CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard

FNALbuild · 2021-08-16T17:24:55Z

CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard

FNALbuild · 2021-08-16T17:25:30Z

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

FNALbuild · 2021-08-16T17:25:30Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2021-08-16T17:25:49Z

CI build for SBND on slf7 for e20:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

FNALbuild · 2021-08-16T17:25:49Z

CI build for SBND on slf7 for c7:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

FNALbuild · 2021-08-16T17:46:40Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2021-08-16T17:48:02Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

pgreen135 · 2021-08-16T19:51:55Z

@marcodeltutto can you have a look over the CI test results above, are these expected? there are two failures (the detsim stage for each test)

wesketchum · 2021-08-16T21:40:14Z

I'm worried these are not expected errors:

60: %MSG-s ArtException:  PostEndJob 16-Aug-2021 12:36:13 CDT ModuleEndJob
61: ---- EventProcessorFailure BEGIN
62:   EventProcessor: an exception occurred during current event processing
63:   ---- ScheduleExecutionFailure BEGIN
64:     Path: ProcessingStopped.
65:     ---- ProductNotFound BEGIN
66:       getView: Found no products matching all criteria
67:       Looking for sequence of type: sim::SimChannel
68:       Looking for module label: simdrift
69:       Looking for productInstanceName: 
70:       The above exception was thrown while processing module SimWireSBND/daq run: 1 subRun: 0 event: 1
71:     ---- ProductNotFound END
72:     Exception going through path simulate
73:   ---- ScheduleExecutionFailure END
74: ---- EventProcessorFailure END
75: %MSG
76: Art has completed and will exit with status 1.

Looks like a bad fhicl?

jzennamo · 2021-08-16T22:04:50Z

As far as I understand it the CI tests that are failing are doing so because they are trying to run DetSim over the reference files, but since G4 changed I don't think that this should work since there are data products missing. From my reading of these test outputs we should be OK.

Once this is merged we should update the reference files immediately.

wesketchum · 2021-08-16T22:13:10Z

Issue #149 filed to capture this.

marcodeltutto added 30 commits July 30, 2021 14:53

Current g4 fcl to legacy_*.fcl

121ae6c

Renames the current standard_g4_sbnd.fcl to legacy_g4_sbnd.fcl, as well as the simulationservices_sbnd.fcl and largeantmodules_sbnd.fcl.

Current detsim fcl to legacy_*.fcl

68a70b0

Renames the current standard_detsim_sbnd.fcl to legacy_detsim_sbnd.fcl, and adds legacy configurations to detsimmodules_sbnd.fcl and opdetdigitizer_sbnd.fcl.

Adds line with gdml file with no wires

47527cb

Fix GDML name and clean up file

6abc9b0

Adds SavePriorSCE: true, so SimEnergyDeposits are saved also before SCE

f007b9d

Changes input simulation label for optical fast simulation to ionands…

0bb0587

…cint:priorSCE

Fix gdml file name, improve comments

66c0d61

Legacy G4 files in their own folder

08642f7

- Add a legacy folder inside the g4 one to store all the legacy g4 files - Move legacy_detsim_sbnd.fcl and legacy_g4_sbnd.fcl to the legacy/ folder - Create a legacy/others/ folder for all the others g4 legacy fcls

Add the legacy folder to cmakelists

f5027f1

Add the hybrid model to standard_g4_sbnd.fcl (commented out for now)

51d5cc0

Move g4-related fcls to a g4 folder

e7a00c7

Adds SensDet tags to volCryostat, volFieldCage, volXArapuca, volPMT, …

e7d8a3f

…volPDSstructure, and volTPCPlaneVert

Add units to SensDet auxiliary to avoid warnings

e878d8e

Detsim fcls for legacy larg4 to their own legacy/ folder

c3d3a1c

Move PDFastSim_sbnd.fcl back to LArSoftConfigurations

67e4dcd

Add configuration to run g4 with hybrid optical mode

ba04151

Fix g4_mu_crt_filter_base.fcl to use new simulate path

10678e5

Disable largeant and daq from prodsingle_sbnd.fcl

ffe80a3

Add LArG4 to CMakeLists.txt

8c796db

Remove refactored folder

ef8a72a

Clean up standard_detsim_sbnd.fcl

3997837

Separate the gdml for the optical hybrid model

9955674

Sparsify LArG4 trajectories, and set correct gdml for op hybrid model

83f3a90

Revert sbnd_v02_00_withshielding gdml files to previous configuration

dedd097

Improve comments

ce6f79d

Clean up ionandscint_sbnd.fcl fcl

8abeebc

Enable QL-anticorrelation by default in ionandscint

2f2e6c2

Merge branch 'develop' into mdeltutt_larg4_migration

f15415a

Move g4_QLcorrelated.fcl and g4_QLseparate.fcl to legacy folder.

5845860

jzennamo approved these changes Aug 13, 2021

View reviewed changes

sbndcode/Geometry/gdml/sbnd_v02_00_base.gdml Show resolved Hide resolved

sbndcode/JobConfigurations/standard/standard_detsim_sbnd.fcl Show resolved Hide resolved

wesketchum mentioned this pull request Aug 16, 2021

Update CI reference files for v09_28_01 #149

Closed

pgreen135 merged commit 810fe0c into develop Aug 17, 2021

This was referenced Aug 18, 2021

Standard anatree no longer runs with new g4 changes #154

Closed

Use new module label for sim channels #156

Merged

pgreen135 deleted the mdeltutt_larg4_migration branch August 21, 2021 11:46

henrylay97 mentioned this pull request Aug 25, 2021

Seg faults when running g4 stage in recent sbndcode versions #165

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration to the Refactored LArG4 #134

Migration to the Refactored LArG4 #134

marcodeltutto commented Aug 4, 2021 •

edited

Loading

jzennamo left a comment

pgreen135 commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

pgreen135 commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

pgreen135 commented Aug 16, 2021

wesketchum commented Aug 16, 2021

jzennamo commented Aug 16, 2021

wesketchum commented Aug 16, 2021

Migration to the Refactored LArG4 #134

Migration to the Refactored LArG4 #134

Conversation

marcodeltutto commented Aug 4, 2021 • edited Loading

Open Items

FHICL files

Optical

CRT

Known Issues

jzennamo left a comment

Choose a reason for hiding this comment

pgreen135 commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

pgreen135 commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

FNALbuild commented Aug 16, 2021

pgreen135 commented Aug 16, 2021

wesketchum commented Aug 16, 2021

jzennamo commented Aug 16, 2021

wesketchum commented Aug 16, 2021

marcodeltutto commented Aug 4, 2021 •

edited

Loading