Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help view: word wrap not right #14

Open
eekee opened this issue Feb 17, 2018 · 4 comments
Open

help view: word wrap not right #14

eekee opened this issue Feb 17, 2018 · 4 comments

Comments

@eekee
Copy link

eekee commented Feb 17, 2018

i opened help by launcher menu->help. on that page, visible without scrolling or resizing the window, a line of text goes off the right side of the window.

"resizable windows have an extra bar at the bottom, that is the same color of the title ba"

the right side of the 'a' is cut off. further down, the "Close Task" line is a little bit cut off, and the "Bring To Top" line's period is off the edge.

image

one thing i've learned over the years is you can't really precompute text size for most types of interface. You can't rely on how it will be rendered.

@ThomasTheSpaceFox
Copy link

it will require some tweaking to the text rendering functions, though thankfully they aren't that complicated at the moment, so it shouldn't be too hard. Pygame does have functions to calculate text width before hand, so those might be useful.

@ThomasTheSpaceFox
Copy link

see 8a73cb3 It does leave an extra space thats visible in links, but its both newline and word-wrap aware. so we will need to go through the pages and do some minor reformatting.

@eekee
Copy link
Author

eekee commented Feb 20, 2018

nice! i'll do some reformatting now, i think. it'll be easier than actually thinking this morning. :)

@eekee
Copy link
Author

eekee commented Feb 20, 2018

done some: b70ef5b

i wanted to add more spacing to the file types page, because to my eyes it looks like the icons are more closely associated with the line below. i don't know how to add vertical spacing though, extra newlines don't work. actual divisions were too much, and confused matters around the 'general types' heading. i've misused text to add some extra space above that heading for now, but left the rest as-is.

edit: i didn't want to misuse text to add all the vertical spacing i wanted. in part it looks ugly in the xml. in part it adds too much space.

i've changed a line in a list in the help on help. it was nice, but it didn't resize well.

i didn't add bullets to lists. they may need it when the window is very narrow, but when is the window very narrow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants