Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package distribution is not licensed #736

Closed
notnarb opened this issue Oct 1, 2018 · 1 comment
Closed

Package distribution is not licensed #736

notnarb opened this issue Oct 1, 2018 · 1 comment

Comments

@notnarb
Copy link
Contributor

notnarb commented Oct 1, 2018

I hate to be a nag, but I was hoping you could add a licence file to the published Inquirer package.

The MIT licence has the following requirement:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

And the latest currently published version of Inquirer does not include a LICENCE in its distribution:

$ curl -sS $(npm v inquirer dist.tarball) | tar tvzf -
-rw-r--r-- 0/0            1221 1985-10-26 01:15 package/package.json
-rw-r--r-- 0/0            2342 1985-10-26 01:15 package/lib/inquirer.js
-rw-r--r-- 0/0             921 1985-10-26 01:15 package/lib/objects/choice.js
-rw-r--r-- 0/0            2753 1985-10-26 01:15 package/lib/objects/choices.js
-rw-r--r-- 0/0             779 1985-10-26 01:15 package/lib/objects/separator.js
-rw-r--r-- 0/0            3609 1985-10-26 01:15 package/lib/prompts/base.js
-rw-r--r-- 0/0            6092 1985-10-26 01:15 package/lib/prompts/checkbox.js
-rw-r--r-- 0/0            1850 1985-10-26 01:15 package/lib/prompts/confirm.js
-rw-r--r-- 0/0            2330 1985-10-26 01:15 package/lib/prompts/editor.js
-rw-r--r-- 0/0            6378 1985-10-26 01:15 package/lib/prompts/expand.js
-rw-r--r-- 0/0            2219 1985-10-26 01:15 package/lib/prompts/input.js
-rw-r--r-- 0/0            4445 1985-10-26 01:15 package/lib/prompts/list.js
-rw-r--r-- 0/0             694 1985-10-26 01:15 package/lib/prompts/number.js
-rw-r--r-- 0/0            2248 1985-10-26 01:15 package/lib/prompts/password.js
-rw-r--r-- 0/0            4036 1985-10-26 01:15 package/lib/prompts/rawlist.js
-rw-r--r-- 0/0            1791 1985-10-26 01:15 package/lib/ui/baseUI.js
-rw-r--r-- 0/0            2349 1985-10-26 01:15 package/lib/ui/bottom-bar.js
-rw-r--r-- 0/0            3056 1985-10-26 01:15 package/lib/ui/prompt.js
-rw-r--r-- 0/0            1368 1985-10-26 01:15 package/lib/utils/events.js
-rw-r--r-- 0/0            1489 1985-10-26 01:15 package/lib/utils/paginator.js
-rw-r--r-- 0/0            1179 1985-10-26 01:15 package/lib/utils/readline.js
-rw-r--r-- 0/0            3860 1985-10-26 01:15 package/lib/utils/screen-manager.js
-rw-r--r-- 0/0             780 1985-10-26 01:15 package/lib/utils/utils.js

(sorry, yes, I know this is nitpicky)

lerna/lerna#1213 (closed by lerna/lerna#1465) should hopefully make this automatic by just re-publishing this package now that you are using Lerna 3.

(LICENSE-MIT may also need to be renamed to LICENSE to make this fully automatic)

Thank you for your work in Inquirer!

@notnarb
Copy link
Contributor Author

notnarb commented Feb 27, 2019

As of today, this issue is still present:

$ curl -sS $(npm v inquirer dist.tarball) | tar tvzf -
-rw-r--r-- 0/0            1327 1985-10-26 01:15 package/package.json
-rw-r--r-- 0/0           16945 1985-10-26 01:15 package/README.md
-rw-r--r-- 0/0            2344 1985-10-26 01:15 package/lib/inquirer.js
-rw-r--r-- 0/0             921 1985-10-26 01:15 package/lib/objects/choice.js
-rw-r--r-- 0/0            2755 1985-10-26 01:15 package/lib/objects/choices.js
-rw-r--r-- 0/0             779 1985-10-26 01:15 package/lib/objects/separator.js
-rw-r--r-- 0/0            3609 1985-10-26 01:15 package/lib/prompts/base.js
-rw-r--r-- 0/0            6102 1985-10-26 01:15 package/lib/prompts/checkbox.js
-rw-r--r-- 0/0            1851 1985-10-26 01:15 package/lib/prompts/confirm.js
-rw-r--r-- 0/0            2330 1985-10-26 01:15 package/lib/prompts/editor.js
-rw-r--r-- 0/0            6387 1985-10-26 01:15 package/lib/prompts/expand.js
-rw-r--r-- 0/0            2220 1985-10-26 01:15 package/lib/prompts/input.js
-rw-r--r-- 0/0            4447 1985-10-26 01:15 package/lib/prompts/list.js
-rw-r--r-- 0/0             695 1985-10-26 01:15 package/lib/prompts/number.js
-rw-r--r-- 0/0            2212 1985-10-26 01:15 package/lib/prompts/password.js
-rw-r--r-- 0/0            4826 1985-10-26 01:15 package/lib/prompts/rawlist.js
-rw-r--r-- 0/0            1792 1985-10-26 01:15 package/lib/ui/baseUI.js
-rw-r--r-- 0/0            2350 1985-10-26 01:15 package/lib/ui/bottom-bar.js
-rw-r--r-- 0/0            3057 1985-10-26 01:15 package/lib/ui/prompt.js
-rw-r--r-- 0/0            1368 1985-10-26 01:15 package/lib/utils/events.js
-rw-r--r-- 0/0            1490 1985-10-26 01:15 package/lib/utils/paginator.js
-rw-r--r-- 0/0            1179 1985-10-26 01:15 package/lib/utils/readline.js
-rw-r--r-- 0/0            3864 1985-10-26 01:15 package/lib/utils/screen-manager.js
-rw-r--r-- 0/0             780 1985-10-26 01:15 package/lib/utils/utils.js

notnarb added a commit to notnarb/Inquirer.js that referenced this issue Feb 27, 2019
 * lerna/lerna#1465 adds LICENSE files to published packages (a requirement by
   the MIT license), this rename should allow lerna to detect the correct
   license file when publishing.

Closes SBoudrias#736
SBoudrias pushed a commit that referenced this issue Mar 4, 2019
* lerna/lerna#1465 adds LICENSE files to published packages (a requirement by
   the MIT license), this rename should allow lerna to detect the correct
   license file when publishing.

Closes #736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant