Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility fix #1042 #1048

Merged
merged 2 commits into from
Sep 15, 2021
Merged

compatibility fix #1042 #1048

merged 2 commits into from
Sep 15, 2021

Conversation

SanariSan
Copy link
Contributor

@SanariSan SanariSan commented Sep 15, 2021

Fix of #1042 #1045
For compatibility with older versions of node ES2020 operator been replaced with explicit check.

this.selected =
        this.selected !== null && this.selected !== undefined ? this.selected : -1;

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #1048 (2fb23d6) into master (c4a3c23) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
+ Coverage   93.20%   93.40%   +0.19%     
==========================================
  Files          27       27              
  Lines        1163     1167       +4     
  Branches       25       25              
==========================================
+ Hits         1084     1090       +6     
+ Misses         79       77       -2     
Impacted Files Coverage Δ
packages/inquirer/lib/prompts/base.js 92.45% <100.00%> (+0.29%) ⬆️
packages/inquirer/lib/prompts/checkbox.js 98.19% <100.00%> (ø)
packages/inquirer/lib/prompts/input.js 100.00% <100.00%> (+2.38%) ⬆️
packages/inquirer/lib/prompts/password.js 100.00% <100.00%> (ø)
packages/inquirer/lib/prompts/rawlist.js 98.87% <100.00%> (+0.01%) ⬆️
packages/inquirer/lib/ui/prompt.js 100.00% <100.00%> (ø)
packages/inquirer/lib/utils/screen-manager.js 92.85% <0.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47dfcaf...2fb23d6. Read the comment docs.

@SBoudrias SBoudrias merged commit 8648ee8 into SBoudrias:master Sep 15, 2021
@SBoudrias
Copy link
Owner

Thanks for handling quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants