Build script to setup ESM/CJS module exports #1185
Conversation
gfortaine
force-pushed
the
master
branch
5 times, most recently
from
9acf6e1
to
b99b1d7
Compare
| @@ -0,0 +1,3 @@ | |||
| const inquirer = require("./inquirer.js").default; | |||
There was a problem hiding this comment.
This file sneaked in the diff (prob added/commited before the .gitignore change)
There was a problem hiding this comment.
Oh I see this is desired. Let's update the .gitignore so this file is included not ignored by Git.
| import chalk from 'chalk'; | ||
| import cliCursor from 'cli-cursor'; | ||
| import figures from 'figures'; | ||
| import chalk from '#chalk'; |
There was a problem hiding this comment.
Is there eslint rules to enforce to use the # imports if the dependency is found in the package.json import map. That would help enforce it for future collaborators.
There was a problem hiding this comment.
We'll also need to fix the node/no-missing-import eslint error before merging.
| @@ -0,0 +1,3 @@ | |||
| const inquirer = require("./inquirer.js").default; | |||
There was a problem hiding this comment.
I'd recommend adding this file to the eslint ignore. It errors on CI now since it's using common.js syntax - and wouldn't compile as-is.
|
Thanks a ton for that awesome PR! 🙏🏻 Let me know if you need help to resolve any issues |
|
Hey, so I tried to dig a bit that eslint issue. I've updated the This PR seems to imply ESM |
fix #1159