Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment skipped tests out #1228

Closed

Conversation

LitoMore
Copy link
Collaborator

@LitoMore LitoMore commented May 8, 2023

To fix the failing CI https://github.com/SBoudrias/Inquirer.js/actions/runs/4910589207.

I'm also checking why the test prevent returning promises from useEffect hook fails.

How to reproduce the failing CI

# project root
CI=true yarn test

The documentation of this behavior can be found at https://vitest.dev/guide/cli.html#options, the --allowOnly option.

The --allowOnly will be set to false when in CI.

@LitoMore LitoMore requested a review from SBoudrias May 8, 2023 10:03
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.15 🎉

Comparison is base (12fecef) 78.80% compared to head (37e37fd) 78.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
+ Coverage   78.80%   78.95%   +0.15%     
==========================================
  Files          34       34              
  Lines        3496     3574      +78     
  Branches      558      567       +9     
==========================================
+ Hits         2755     2822      +67     
- Misses        187      189       +2     
- Partials      554      563       +9     
Impacted Files Coverage Δ
packages/core/src/index.mts 77.36% <69.69%> (-2.30%) ⬇️
packages/core/core.test.mts 86.95% <93.84%> (+2.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SBoudrias SBoudrias closed this in 303d12b May 8, 2023
@SBoudrias
Copy link
Owner

Fixed it properly with that commit.

@LitoMore LitoMore deleted the comment-skipped-tests-out branch May 8, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants