Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkbox ts type prompt error #1229

Closed
wants to merge 1 commit into from

Conversation

zonemeen
Copy link
Collaborator

@zonemeen zonemeen commented May 9, 2023

The checkbox ts type prompt error.

1683599319107

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ac98a1) 78.76% compared to head (c0cf591) 78.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1229   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files          34       34           
  Lines        3575     3575           
  Branches      576      576           
=======================================
  Hits         2816     2816           
  Misses        187      187           
  Partials      572      572           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SBoudrias
Copy link
Owner

Is this error occurring when you use the checkbox? Or you see it in your editor when editing Inquirer? (because CI is passing 🤔)

The idea is that the value is inferred from whichever type is passed in. The change proposed force the value to always be a string; but this might not be what someone wants.

@zonemeen
Copy link
Collaborator Author

No error is reported when using it, it's the typescript prompt in my Webstorm editor that reports an error.

@SBoudrias
Copy link
Owner

Hum weird, it works fine in VSCode for me. Maybe check you're using the workspace typescript version?

I'll close this PR since the solution change the expected behaviour, and it doesn't impact end users/CI.

@SBoudrias SBoudrias closed this May 10, 2023
@zonemeen zonemeen deleted the fix/checkbox-types branch May 10, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants