Adds an option to configure input/output streams, fixes #279 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +29,7 @@ var UI = module.exports = function (opt) { | |||
| process.on('exit', this.onForceClose); | |||
|
|
|||
| // Propagate keypress events directly on the readline | |||
| process.stdin.addListener('keypress', this.onKeypress); | |||
| this._input.addListener('keypress', this.onKeypress); | |||
There was a problem hiding this comment.
I'm fairly certain we can just call this.rl.output/this.rl.input without requiring us to keep the reference around.
ruyadorno
force-pushed
the
add-configurable-streams
branch
from
320144f
to
e7f1703
Compare
|
👍 addressed all comments |
|
Awesome, thanks a ton! |
SBoudrias
added a commit
that referenced
this pull request
Sep 7, 2015
Adds an option to configure input/output streams, fixes #279
|
🎊 |
This was referenced Sep 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a third option to the
inquirer.promptmethod to allow for configurable input/output streams.When no value is supplied defaults to
process.stdin/process.stdout.@SBoudrias