Fix for not clearing final line #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that fix is fine given it should only impact force close. As far as I understand #506 problem, it was about prompt closed following usual process (answer all question and be done with Inquirer) But so in your case, the only time the prompt isn't cleaned properly is when you |
|
Yes only on force close. The prompt is cleared until the last line but only horizontally to the position of the cursor position. |
|
Okay, I'll release it tonight (in my TZ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you test this @SBoudrias ? This restores the correct functionality without giving an extra line for me, same for you?
Before you had an console.log('\n') there, but gives an extra line.