Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to RxJS 5 #614

Merged
merged 1 commit into from
Jan 8, 2018
Merged

upgrade to RxJS 5 #614

merged 1 commit into from
Jan 8, 2018

Conversation

user3587412
Copy link
Contributor

Hello, this pull request upgrades RxJS to version 5

@SBoudrias
Copy link
Owner

I'm wondering, so there's no more rx lite?

@user3587412
Copy link
Contributor Author

To my knowledge, no. However starting with RxJS 5 we can use prototype patching to import just the operators we need. They've also recently added lettable operators as an alternative.

@SBoudrias
Copy link
Owner

Thanks for your answer. I'll merge this branch, but not right now as I just released a major version. I want to make sure this release is stable before pushing a new one out.

@kbrandwijk
Copy link
Contributor

Any plans for releasing this?

@SBoudrias
Copy link
Owner

@kbrandwijk are you waiting for this for new features?

@kbrandwijk
Copy link
Contributor

I'm looking to get started with it, and I want to plan it a bit, so if I start now, I won't be confronted with an upgrade to v5 in two weeks 😄

@SBoudrias SBoudrias merged commit 258064f into SBoudrias:master Jan 8, 2018
@SBoudrias
Copy link
Owner

I'll cut a release later today :)

@soruly
Copy link

soruly commented Feb 27, 2018

moving to RxJS 5 adds 3000+ more files in node_modules
RxJS put all their source code and source map in production node_modules
ReactiveX/rxjs#3334

I'd refrain from upgrading and keep using 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants