Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped version to 4.1.0, bumped external-editor dependency to ^2.1.0 … #616

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Bumped version to 4.1.0, bumped external-editor dependency to ^2.1.0 … #616

merged 2 commits into from
Nov 27, 2017

Conversation

kreig303
Copy link

…to remove jschardet LGPL license dependency.

Final fix for Issue #574.

…to remove jschardet LGPL license dependency.
@kreig303 kreig303 mentioned this pull request Nov 27, 2017
@kreig303
Copy link
Author

Ran npm test too... first time it failed on

1) inquirer.prompt
       hierarchical mode (`when`)
         should run prompt if `when` returns true:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

but then the second time (et seq.) it ran fine... just fyi?

@SBoudrias SBoudrias merged commit 9895054 into SBoudrias:master Nov 27, 2017
@SBoudrias
Copy link
Owner

Thanks! I'll make a release tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants