Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct subscription method #640

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Correct subscription method #640

merged 1 commit into from
Jan 20, 2018

Conversation

user3587412
Copy link
Contributor

Fixes #637

forEach now returns a promise instead of a disposable subscription (therefore .dispose() does not exist)

@SBoudrias
Copy link
Owner

Thanks!

@SBoudrias SBoudrias merged commit bd79918 into SBoudrias:master Jan 20, 2018
@sjmarshy sjmarshy mentioned this pull request Jan 27, 2018
Open
@sjmarshy sjmarshy mentioned this pull request Jun 2, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@user3587412 @SBoudrias