Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rxjs 6 upgrade #676

Merged
merged 1 commit into from May 14, 2018
Merged

rxjs 6 upgrade #676

merged 1 commit into from May 14, 2018

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented May 10, 2018

Hi again!

This is a follow-up PR from our discussion here: #652

I followed rxjs's MIGRATION.md.

Thanks for having such a comprehensive test suite. 馃 馃

@imhoffd
Copy link
Contributor Author

imhoffd commented May 10, 2018

This would be a breaking change, of course.

@SBoudrias SBoudrias merged commit 78bd4da into SBoudrias:master May 14, 2018
@SBoudrias
Copy link
Owner

Thanks!!

@sjmarshy sjmarshy mentioned this pull request Jun 2, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imhoffd @SBoudrias