Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi rawList bug (#861) #867

Merged
merged 2 commits into from Dec 15, 2019
Merged

Conversation

xiaoxielnino
Copy link
Contributor

Sorry about that removing some features. And I have re-added the features that doesn't need to be removed. And also fix the prettier warning on the CI. please take a check. Thanks.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #867 into master will increase coverage by 1.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage   92.18%   93.22%   +1.04%     
==========================================
  Files          26       26              
  Lines        1062     1063       +1     
  Branches       23       23              
==========================================
+ Hits          979      991      +12     
+ Misses         83       72      -11
Impacted Files Coverage Δ
packages/inquirer/lib/prompts/rawlist.js 98.85% <100%> (+12.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8248ee5...00e4c0d. Read the comment docs.

@xiaoxielnino
Copy link
Contributor Author

I've seen many codecov/patch weird behavior compared to codecov/project which was always properly reporting the coverage as expected.
And I don't know how the pass the codecov/patch, if there is an example for codecov/patch, please help me out.
Unless someone thinks codecov/patch is needed for a good reason, I think keeping codecov/project only will be enough.

@xiaoxielnino
Copy link
Contributor Author

I've seen many codecov/patch weird behavior compared to codecov/project which was always properly reporting the coverage as expected.
And I don't know how the pass the codecov/patch, if there is an example for codecov/patch, please help me out.
Unless someone thinks codecov/patch is needed for a good reason, I think keeping codecov/project only will be enough.

It seems that I should add the unit test to pass the ci. Please have a check. Thanks.

@SBoudrias
Copy link
Owner

Thanks for the bug fix, it appears to be working fine 👍

@SBoudrias SBoudrias merged commit 904e473 into SBoudrias:master Dec 15, 2019
jdoyle65 pushed a commit to jdoyle65/Inquirer.js that referenced this pull request Jan 19, 2021
* fix multi rawList bug (SBoudrias#861)

* feat: add  rawlist unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants