→ Fix common cross-platform issue with file path normalization. #86
Conversation
…en gulp3 & gulp4 the way file paths may have changed. Reference: SBoudrias/gulp-istanbul/SBoudrias#48
Re: SBoudrias/gulp-istanbul/SBoudrias#48
| @@ -15,6 +15,11 @@ var PluginError = gutil.PluginError; | |||
| var PLUGIN_NAME = 'gulp-istanbul'; | |||
| var COVERAGE_VARIABLE = '$$cov_' + new Date().getTime() + '$$'; | |||
|
|
|||
| function getNormalizedPath(filepath) { | |||
There was a problem hiding this comment.
Pretty sure we could simply use https://www.npmjs.com/package/normalize-path
There was a problem hiding this comment.
I guess I probably should have named the function better... This is actually making sure the original platform file path separator is used. I think that normalize-path just makes everything use /, not sure if that would work or not. But I'll give it a try and see...
This isn't my project, so if it does work and you'd prefer to use an external dependency that's fine. But generally if what I'm needing from an external module is just a single line of code, it seems a bit of an excess to require external dependencies for that...
There was a problem hiding this comment.
I plugged in the normalize-path module, but as I feared it didn't fully function. It did better than without it, but for some reason the number of statements passing coverage dropped by 50%.
Also, in the generated report the paths included the entire file path including hard drive letter rather than a relative path based on the root project directory. Versus using the original platform path separator which makes it work the same on Windows as it does on Mac/linux...
There was a problem hiding this comment.
let's give a better name to that function then. normalizePathSep() or something
|
@afloyd hey, any chance to get the code fix so we can merge? |
… per @SBoudrias Re: SBoudrias/gulp-istanbul/SBoudrias#48 Re: SBoudrias/gulp-istanbul/SBoudrias#86
|
I'm sorry, it is still conflicting. Try |
# Conflicts: # index.js
|
Thanks for sending this out! |
Between gulp3 & gulp4 the way file paths are generated may have changed.
Reference: SBoudrias/gulp-istanbul/#48