Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to skip path resolution #91

Merged
merged 2 commits into from
May 2, 2016

Conversation

nimrod-becker
Copy link
Contributor

Considering aggregating coverage reports on the same code, but from different installations or locations, linux installation and windows installation for example. In such cases, if the source files would appear under different paths their coverage won't be aggregated into a single asset, but rather would appear per each unique path.

Provide an option to skip path resolution and work with the provided paths (relative in the mentioned case) thus enabling aggregation.

See #90

@SBoudrias
Copy link
Owner

If it works without calling path.resolve, why offering the option at all?

@nimrod-becker
Copy link
Contributor Author

Only reason I thought of was backward compatibility, but if you don't find it that important, can easily be removed.

@SBoudrias
Copy link
Owner

Yeah, let's just remove it!

@nimrod-becker
Copy link
Contributor Author

Are we going ahead with it ?

@SBoudrias
Copy link
Owner

Yes, I didn't see you pushed a new diff (github doesn't notify you when it happen).

Thanks for sending the PR!

@SBoudrias SBoudrias merged commit 99432aa into SBoudrias:master May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants