-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for templates in destination paths is using characters reserved on Windows. #115
Comments
But we do replace these characters before trying to touch the file system. Can you explain more in which way this is breaking in your case? |
In case of repository there is In real use (like yeoman generator) my understanding is that templates would be part of folder and file names inside of the generator so they have to be written to file system when generator is installed and later they would be replaced when generating project. |
Oh my bad, I totally missed that... We shouldn't have a folder with The template should only be applied when creating a dynamic destination. It shouldn't be in the actual path source. |
Now that directory variables have been removed. How do we implement this? I am using yeoman which uses this library, and want to template the package (directory) names. Are there any examples? |
I've created PR #117, that introduce |
The feature is still working fine, we just changed the test files. The idea is that you don't want to literally have the template inside of the file system. You just use the template literals inside you paths. |
Sorry I should have specified, I am using the glob syntax '**' to recursively copy everything from a template directory. It would be nice to have some way express varibles in the folder and file names? Obviously, the token match should be changed to something that is windows compatible if possible. |
Hi, I'm in the same case. Can you reopen the issue ? This is commited on git, and process further with copyTpl with globOptions: {dot: true} To resolve this, we need
Can you look at it ? Thanks |
Hello from 2023! this.fs.copyTpl(
this.templatePath(),
this.destinationPath(),
{
name: this.props.name,
},
{
name: this.props.name,
delimiter: "#",
openDelimiter: "{",
closeDelimiter: "}"
}
); |
Recently added support for templates in destination paths (2bb43b7, #106) is using
<
and>
that are reserved characters on Windows. Because of that is it currently impossible to checkout master and any project/generator that would use this would break.The text was updated successfully, but these errors were encountered: