Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abs rrule for Unitful.Quantity #8

Closed
SBuercklin opened this issue Jul 2, 2022 · 0 comments · Fixed by #9
Closed

abs rrule for Unitful.Quantity #8

SBuercklin opened this issue Jul 2, 2022 · 0 comments · Fixed by #9

Comments

@SBuercklin
Copy link
Owner

abs's rrule returns a deconstructed Quantity as a NamedTuple, not a Quantity. We should add a manual rule to fix this and upstream to ChainRules.jl if it generalizes the existing behavior

julia> Zygote.gradient(abs, 1u"W")
((val = 1.0 W,),)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trig over Degrees, ustrip SBuercklin/UnitfulChainRules.jl
1 participant
@SBuercklin