Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using 3 or more modifiers gives error #1037

Closed
dawidk92 opened this issue Nov 18, 2016 · 2 comments
Closed

Using 3 or more modifiers gives error #1037

dawidk92 opened this issue Nov 18, 2016 · 2 comments

Comments

@dawidk92
Copy link

It would be nice if :active will work the same as :hover in KSS notation.

// Button
//
// default - default button
// :hover - hover button
// :active - active button

Right now ':active' throws error:
"Styleguide generation failed
Error: TypeError: varName.substring is not a function in $file"
@varya
Copy link
Contributor

varya commented Dec 27, 2016

Hey. I suspect that the problem is not :active modifier but using 3 or more modifiers. If you change :active to anything like .class - Smth, is there the same problem? If there is, then the fix will be soon merged #1050

@dawidk92
Copy link
Author

Yep, you're right. Error occurs when there are used 2 or more pseudo classes.
:active works alone but with use of :hover it doesn't any more

@varya varya changed the title Add :active as $modifier Using 3 or more modifiers gives error Dec 28, 2016
@varya varya closed this as completed in c6e277d Dec 28, 2016
varya added a commit that referenced this issue Dec 28, 2016
@varya
Merge pull request #1050 from varya/fix/1037_active-modifier
a7b0fba 
Parse additional params correctly if many modifiers are in use. Fix #1037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@varya @dawidk92