Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use html files as markup? #701

Closed
rryter opened this issue Jul 11, 2015 · 3 comments
Closed

How to use html files as markup? #701

rryter opened this issue Jul 11, 2015 · 3 comments

Comments

@rryter
Copy link

rryter commented Jul 11, 2015

Hit there

I'm probably missing something, I can not get the "Markup: file.html" syntax to work, it always displays the text instead of the html from the file.

// Tabs
//
// markup: tabs.html
//
// Styleguide 2.1

The spec says:

Instead of using inline HTML markup, you could point at a separate file that contains your HTML. kss-node supports either a plain *.html file or a Handlebars *.hbs file. The kss-node generator will search for the markup file in any of the --source folders.

Does that mean that I should place the .html file where my sass files are? And then change gulp.src?
Because when I do that the server fails to start.

This is how my generate task currently looks like (coffeescript):

  gulp.src(['./app/styles/**/*.scss', '!./app/styles/helper/*.scss'])
      .pipe(plugins.styleguide.generate(
          title: 'localsearch.ch Styleguide'
          server: true
          port: 3002
          styleVariables: './app/styles/settings/variables.scss'
          rootPath: 'styleguide'
          overviewPath: 'README.md'))
      .pipe gulp.dest('styleguide')

If anyone could shed some light into this I would appreciate it. I'll also gladly write the docs for this as soon as I know how it's supposed to work.

Many thanks.

@g12n
Copy link

g12n commented Jul 16, 2015

I am currently having exactly the same problem

@H1D
Copy link

H1D commented Jul 17, 2015

Same here! If I add html as a source it just says Syntax "html" is not supported yet, sorry

varya added a commit to varya/sc5-styleguide that referenced this issue Jul 21, 2015
@varya
Copy link
Contributor

varya commented Jul 21, 2015

Hi. Inserting html file is not a part of KSS parser, so it did not appear in the SC5 styleguide when we updated it to KSS 2.0. But I implemented this feature as well #721 You need to wait for the PR to be merged and released.

I also created a "refactoring" issue which would let us avoid such situations. #722

varya added a commit that referenced this issue Jul 22, 2015
Fix #701. Allow markup to refer to an html file
@varya varya closed this as completed in fc83266 Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants