Use parsed includeDefaultStyles instead of direct input #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
commented
Mar 16, 2018
| @@ -254,15 +254,6 @@ function filterFiles(files, filter) { | |||
| } | |||
|
|
|||
| module.exports.generate = function(options) { | |||
| try { | |||
| if (options.includeDefaultStyles) { | |||
There was a problem hiding this comment.
At this point options.includeDefaultStyles hasn't gone through common.sanitizeOptions() so the default includeDefaultStyles is false.
|
Great job, @kasparsd ! |
|
Is there a way to get this merged and published to NPM? |
|
Could we please get this merged in? |
junaidrsd
approved these changes
Jun 19, 2018
|
@junaidrsd Totally understand. Sure, I would love to help keep it updated and working. |
|
@kasparsd Thank you. Great to hear that you want to contribute. I've invited you as a collaborator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for code review.
Fixes #1128 and #1115.