Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinsamanka/feature/#2135 tango controls support 2 7 2 #2401

Open
wants to merge 4 commits into
base: release/2.7.4
Choose a base branch
from

Conversation

Limraj
Copy link
Collaborator

@Limraj Limraj commented Nov 21, 2022

No description provided.

@Limraj Limraj added this to the 2.7.4 milestone Nov 21, 2022
@github-actions
Copy link

github-actions bot commented Nov 21, 2022

Java JUnit Test Results

1 536 tests  ±0   1 536 ✔️ ±0   23s ⏱️ +3s
     82 suites ±0          0 💤 ±0 
     82 files   ±0          0 ±0 

Results for commit fdd6182. ± Comparison against base commit 978ddf1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 21, 2022

Java Script Mocha Unit Test Results

268 tests  ±0   268 ✔️ ±0   5s ⏱️ ±0s
  70 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit fdd6182. ± Comparison against base commit 978ddf1.

♻️ This comment has been updated with latest results.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

devAttr.insert(iv);
break;
case TangoConst.Tango_DEV_SHORT:
devAttr.insert((short) iv);

Check failure

Code scanning / CodeQL

User-controlled data in numeric cast

This cast to a narrower type depends on a [user-provided value](1), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](2), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](3), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](4), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](5), potentially causing truncation.
devAttr.insert(dv);
break;
case TangoConst.Tango_DEV_FLOAT:
devAttr.insert((float) dv);

Check failure

Code scanning / CodeQL

User-controlled data in numeric cast

This cast to a narrower type depends on a [user-provided value](1), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](2), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](3), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](4), potentially causing truncation. This cast to a narrower type depends on a [user-provided value](5), potentially causing truncation.
*/

@JsonRemoteEntity
public class TangoDataSourceVO extends DataSourceVO<TangoDataSourceVO> {

Check failure

Code scanning / CodeQL

No clone method

No clone method, yet implements Cloneable.
public int eventID;
}

private class EventCallBack extends CallBack {

Check warning

Code scanning / CodeQL

Serializable inner class of non-serializable class

Serializable inner class of non-serializable class [TangoDataSourceRT](1). Consider making the class static or implementing readObject() and writeObject().

private class EventCallBack extends CallBack {

public void push_event(EventData event) {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [CallBack.push_event](1); it is advisable to add an Override annotation.
return new TangoPointLocatorRT(this);
}

public void validate(DwrResponseI18n response) {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.validate](1); it is advisable to add an Override annotation.
this.attribute = attribute;
}

public PointLocatorRT createRuntime() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.createRuntime](1); it is advisable to add an Override annotation.
return new LocalizableMessage("common.default", attribute);
}

public boolean isSettable() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.isSettable](1); it is advisable to add an Override annotation.
this.dataTypeId = dataTypeId;
}

public LocalizableMessage getConfigurationDescription() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.getConfigurationDescription](1); it is advisable to add an Override annotation.
@JsonRemoteProperty
private boolean settable;

public int getDataTypeId() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PointLocatorVO.getDataTypeId](1); it is advisable to add an Override annotation.
@Limraj Limraj modified the milestones: 2.7.4, 2.7.5 Nov 30, 2022
@Limraj Limraj removed this from the 2.7.5 milestone Jan 9, 2023
@Limraj Limraj added this to the 2.7.9 milestone Feb 29, 2024
@Limraj Limraj modified the milestones: 2.7.9, 2.9.0 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant