Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and CI #1

Closed
raymondben opened this issue Nov 27, 2018 · 3 comments
Closed

Tests and CI #1

raymondben opened this issue Nov 27, 2018 · 3 comments
Assignees

Comments

@raymondben
Copy link
Member

raymondben commented Nov 27, 2018

Testing has been very minimal so far!
Add testthat testing, including on a range of datasets and using all possible mirrors. Add CI via travis, appveyor, use covr, all the usual loot.

@raymondben raymondben changed the title Test on other datasets Tests and CI Nov 27, 2018
raymondben pushed a commit that referenced this issue Jan 14, 2019
@kimnewzealand kimnewzealand self-assigned this Feb 7, 2019
@kimnewzealand
Copy link
Collaborator

kimnewzealand commented Feb 7, 2019

I created a couple of unit tests to get the ball rolling.

I noticed two things:

  1. The new prompt in the interactive to onLoad option @daranzolin means I can run the tests manually using test() but halts the tests using check(). Just wondering how you suggest the tests select the options?
  2. the qa_dataset() is returning class tbl_df/tbl/data.frame not yet as qa_dataset @raymondben so it is failing.

@kimnewzealand
Copy link
Collaborator

  1. is no longer an issue, Check is now running

@raymondben
Copy link
Member Author

Closing: travis (45ed645), appveyor (ed601fb), codecov (f759531) all enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants