Turn arias duration utility into a module, added rod velocity module #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a couple old un-merged changes that I made in 2020. Can you take a look and let me know if you think any will mess with other parts of your workflows that I don't use?
New RotD velocity module
This module computes RotD velocities, useful for computing PGV. It uses the same RotD100 fortran code, but I also modified that code to include 2 additional (short) periods: 0.0001, 0.001
I also modified bbp_formatter.py such that the bbp2peer method can write out velocities if the new optional argument accel=False (it defaults to true)
Arias duration utility is now a module
There was an existing arias duration utility class (arias_duration.py), I turned it into a module and modified it to also spit out 20/80 durations.