Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples app - Build script error #319

Closed
3 tasks
richardgroves opened this issue Feb 14, 2020 · 1 comment · Fixed by #323
Closed
3 tasks

Samples app - Build script error #319

richardgroves opened this issue Feb 14, 2020 · 1 comment · Fixed by #323

Comments

@richardgroves
Copy link

richardgroves commented Feb 14, 2020

Short description

If the project folder has a space in the path then building the Samples app fails due to an error in the build script phase

Expected behavior

It builds

Actual behavior

Errors with

"Command PhaseScriptExecution failed with a nonzero exit code"

Steps to reproduce

Build Sample app from a folder that has a space in the path

Code example that reproduces the issue

Environment

Catalina 10.15.3, XCode 11.3.1

Library version
1.7.2
Installation method
git clone of repo

  • CocoaPods
  • Carthage
  • Git submodules

iOS version(s)
13.3
Xcode version
11.3.1

Can be fixed by changing Run Script command to:

/usr/libexec/PlistBuddy -c "Set :CFBundleVersion $(git rev-parse --abbrev-ref HEAD)($(git rev-parse --short HEAD))" "$SRCROOT/$INFOPLIST_FILE"

[Added " around final file argument]

@scenee
Copy link
Owner

scenee commented Feb 18, 2020

Thank you @richardgroves! I will fix it.

@scenee scenee mentioned this issue Feb 28, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants