Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio should not let us set the PCA mode to greater than number of samples - 2 #856

Closed
medakk opened this issue Dec 10, 2020 · 6 comments
Closed
Assignees

Comments

@medakk
Copy link
Contributor

medakk commented Dec 10, 2020

image

@sheryjoe
Copy link
Contributor

sheryjoe commented Jan 20, 2021

This should be number of samples - 1 (not 2)

@akenmorris
Copy link
Contributor

akenmorris commented Jan 20, 2021

@sheryjoe , are you sure? We are using 0 based numbering for PCA modes. A model with only two shapes has only mode 0 (n-2). With 3 shapes, 2 modes (0 and 1).

@sheryjoe
Copy link
Contributor

You are right, I forgot about the zero based numbering (might be confusing already for users? ) -- effectively max number of modes = number of samples - 1

@akenmorris
Copy link
Contributor

I don't mind if we use 1-based numbering for modes. Just say the word.

@sheryjoe
Copy link
Contributor

I think 1-based is more intuitive for users (first mode, second mode ... etc). Let's change it to 1-based then, thanks.

@akenmorris
Copy link
Contributor

Using 1-based now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants