New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Studio should not let us set the PCA mode to greater than number of samples - 2 #856
Comments
This should be number of samples - 1 (not 2) |
@sheryjoe , are you sure? We are using 0 based numbering for PCA modes. A model with only two shapes has only mode 0 (n-2). With 3 shapes, 2 modes (0 and 1). |
You are right, I forgot about the zero based numbering (might be confusing already for users? ) -- effectively max number of modes = number of samples - 1 |
I don't mind if we use 1-based numbering for modes. Just say the word. |
I think 1-based is more intuitive for users (first mode, second mode ... etc). Let's change it to 1-based then, thanks. |
Using 1-based now. |
The text was updated successfully, but these errors were encountered: