Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes both support during iSCSI LOGIN and iSNS.
A couple of caveats...
1. checkpatch.pl
BTW, my local run of checkpatch.pl was giving a warning:
However, since this is in user-space code rather than kernel, strscpy is not available! I know we could have checkpatch.pl always ignore
STRLCPY
, but I was wary about doing that as it'd do away with the check for kernel code too.2. Windows iSNS Server
As documented here, the Windows iSNS server doesn't handle updates very well - now including alias updates. OTOH, from https://learn.microsoft.com/en-us/windows-server/get-started/removed-deprecated-features-windows-server-2022