Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iSCSI TargetAlias #189

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

bmeagherix
Copy link
Contributor

This includes both support during iSCSI LOGIN and iSNS.


A couple of caveats...

1. checkpatch.pl

BTW, my local run of checkpatch.pl was giving a warning:

WARNING:STRLCPY: Prefer strscpy over strlcpy - see: https://github.com/KSPP/linux/issues/89
#84: FILE: iscsi-scst/usr/ctldev.c:126:
+       strlcpy(kern_attrs[i].name, ISCSI_TARGET_ALIAS_ATTR_NAME,

However, since this is in user-space code rather than kernel, strscpy is not available! I know we could have checkpatch.pl always ignore STRLCPY, but I was wary about doing that as it'd do away with the check for kernel code too.

2. Windows iSNS Server

As documented here, the Windows iSNS server doesn't handle updates very well - now including alias updates. OTOH, from https://learn.microsoft.com/en-us/windows-server/get-started/removed-deprecated-features-windows-server-2022

The iSNS Server service has now been removed from Windows Server 2022

This includes both support during iSCSI LOGIN and iSNS.
@lnocturno lnocturno merged commit 3c8f66e into SCST-project:master Aug 22, 2023
2 of 3 checks passed
@lnocturno
Copy link
Contributor

Hi Brian,

Thank you for the patch!

Thanks,
Gleb

@bmeagherix bmeagherix deleted the target_alias branch January 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants