Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in recent auto-checks #258

Open
pbulsink opened this issue Jul 3, 2024 · 5 comments · May be fixed by #261
Open

Errors in recent auto-checks #258

pbulsink opened this issue Jul 3, 2024 · 5 comments · May be fixed by #261
Assignees

Comments

@pbulsink
Copy link
Collaborator

pbulsink commented Jul 3, 2024

Two errors have popped up this month in auto-checks.

The first has to do with old versions of fastf1 when cache clearing - not a high priority.

The second is a much harder failure across the board for all fastf1-related functions.

 Error in `py_run_string_impl(code, local, convert)`: KeyError: 'DriverNumber'
@pbulsink
Copy link
Collaborator Author

pbulsink commented Jul 3, 2024

It might be a problem with our randomly selected race that is used for testing.

> f1dataR:::load_race_session()  # Uses 2024 Bahrain Race - returns invisible successfully

> f1dataR:::load_race_session(season = 2022, round = 1))
logger      WARNING 	Failed to load session info data!
core        WARNING 	Failed to load extended driver information!
Error in py_run_string_impl(code, local, convert) : 
  KeyError: 'DriverNumber'
Run `reticulate::py_last_error()` for details.

> f1dataR:::load_race_session(season = 2023, round = 1))  # Returns invisible successfully

@pbulsink
Copy link
Collaborator Author

pbulsink commented Jul 3, 2024

Apparently affects all 2022 data (see the referenced discussion in the above bug report at FastF1). At this point I think we wait until either CRAN gets upset that the tests fail, or the data goes back to normal for 2022.

@pbulsink
Copy link
Collaborator Author

There's no evident fix coming from Formula 1 for the old data so I might update the tests to a more recent year to build correctly. This will end up being a blocking issue if code changes can't pass tests.

@pbulsink
Copy link
Collaborator Author

This may be fixed in FastF1 v3.4.0 per theOehrly/Fast-F1#607

@pbulsink
Copy link
Collaborator Author

This may be fixed in FastF1 v3.4.0 per theOehrly/Fast-F1#607

fixed, but artificially - FastF1 has a self-hosted server that serves as an invisible backup for Formula1 API failures. Should we still migrate to a 'real' Formula1-served results?

@pbulsink pbulsink self-assigned this Jul 29, 2024
pbulsink added a commit to pbulsink/f1dataR that referenced this issue Jul 30, 2024
@pbulsink pbulsink linked a pull request Jul 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant