-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in recent auto-checks #258
Comments
It might be a problem with our randomly selected race that is used for testing. > f1dataR:::load_race_session() # Uses 2024 Bahrain Race - returns invisible successfully
> f1dataR:::load_race_session(season = 2022, round = 1))
logger WARNING Failed to load session info data!
core WARNING Failed to load extended driver information!
Error in py_run_string_impl(code, local, convert) :
KeyError: 'DriverNumber'
Run `reticulate::py_last_error()` for details.
> f1dataR:::load_race_session(season = 2023, round = 1)) # Returns invisible successfully |
Apparently affects all 2022 data (see the referenced discussion in the above bug report at FastF1). At this point I think we wait until either CRAN gets upset that the tests fail, or the data goes back to normal for 2022. |
There's no evident fix coming from Formula 1 for the old data so I might update the tests to a more recent year to build correctly. This will end up being a blocking issue if code changes can't pass tests. |
This may be fixed in FastF1 v3.4.0 per theOehrly/Fast-F1#607 |
fixed, but artificially - FastF1 has a self-hosted server that serves as an invisible backup for Formula1 API failures. Should we still migrate to a 'real' Formula1-served results? |
Two errors have popped up this month in auto-checks.
The first has to do with old versions of fastf1 when cache clearing - not a high priority.
The second is a much harder failure across the board for all
fastf1
-related functions.The text was updated successfully, but these errors were encountered: