Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds load_circuit_details from FastF1 #211

Merged
merged 4 commits into from
Jan 21, 2024
Merged

Conversation

pbulsink
Copy link
Collaborator

Closes #210.

@pbulsink
Copy link
Collaborator Author

Need to add check (fastf1.session has no get_circuit_details() method for FastF1 v<3)

Also lots of the following failure:

── Error ('test-load_session_laps.R:18:3'): load session laps works ────────────
<python.builtin.AttributeError/python.builtin.Exception/python.builtin.BaseException/python.builtin.object/error/condition>
Error in `py_run_string_impl(code, local, convert)`: AttributeError: 'NoneType' object has no attribute 'name'
Run `reticulate::py_last_error()` for details.
Backtrace:
    ▆
 1. └─f1dataR (local) `<fn>`(season = 2022, round = "bahrain", session = "Q", add_weather = TRUE)
 2.   └─reticulate::py_run_string(...) at f1dataR/R/load_session_laps.R:65:5
 3.     └─reticulate:::py_run_string_impl(code, local, convert)

They could be unrelated, I'm checking the stable version now.

@pbulsink
Copy link
Collaborator Author

Version check requires ff1>=3.1

pbulsink added a commit to pbulsink/f1dataR that referenced this pull request Jan 20, 2024
@pbulsink
Copy link
Collaborator Author

non-related actions have the same main failure, see https://github.com/SCasanova/f1dataR/actions/runs/7597232191/job/20691818003?pr=213

@SCasanova
Copy link
Owner

I'm getting fails even on our previous version when I try to push

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (76ca898) 90.19% compared to head (7760aaa) 84.29%.

Files Patch % Lines
R/circuit_details.R 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   90.19%   84.29%   -5.91%     
==========================================
  Files          18       19       +1     
  Lines         622      643      +21     
==========================================
- Hits          561      542      -19     
- Misses         61      101      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbulsink pbulsink mentioned this pull request Jan 21, 2024
@pbulsink pbulsink merged commit 0587a3b into SCasanova:master Jan 21, 2024
5 of 16 checks passed
@pbulsink pbulsink deleted the ff1circuit branch January 22, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporating turns into the telemetry data
2 participants