-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds load_circuit_details
from FastF1
#211
Conversation
Need to add check (fastf1.session has no get_circuit_details() method for FastF1 v<3) Also lots of the following failure:
They could be unrelated, I'm checking the stable version now. |
Version check requires ff1>=3.1 |
non-related actions have the same main failure, see https://github.com/SCasanova/f1dataR/actions/runs/7597232191/job/20691818003?pr=213 |
I'm getting fails even on our previous version when I try to push |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 90.19% 84.29% -5.91%
==========================================
Files 18 19 +1
Lines 622 643 +21
==========================================
- Hits 561 542 -19
- Misses 61 101 +40 ☔ View full report in Codecov by Sentry. |
Closes #210.