Version bump and submission #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 19 19
Lines 641 641
=======================================
Hits 611 611
Misses 30 30 ☔ View full report in Codecov by Sentry. |
|
You should add .DS_Store to .gitignore instead of have it in the repo. You'll have to delete this one, commit the deletion, and commit the .gitignore change. |
|
This PR puts the version at 1.4.1 but we're currently at 1.5.0 in the repo |
|
It might be easier to use a new dev branch, and discard this one, instead of having the PR carry the extra multiple_driver_telem code addition/subtraction and be behind in version num (plus removing the .DS_Store and fixing the out-of-date fastf1) |
|
Yeah good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.