Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release docs #246

Merged
merged 11 commits into from Mar 13, 2024
Merged

Update release docs #246

merged 11 commits into from Mar 13, 2024

Conversation

SCasanova
Copy link
Owner

@SCasanova SCasanova commented Mar 12, 2024

Added a comment about the tarball size (mentioned in the last submission)

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (901ec08) to head (7258e9d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          19       19           
  Lines         635      635           
=======================================
  Hits          605      605           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbulsink
Copy link
Collaborator

You've got Thumbs.db files (windows folder files) mixed in here. Maybe pull them back out and add Thumbs.db to gitignore. You also have four (big) plotting-turn-info-*-1.png files that are likely leftovers from when you tried to build vignettes with smaller images, you should pull them out too

@SCasanova
Copy link
Owner Author

Wow that's odd. I don't even have windows. Will remove

@SCasanova SCasanova requested a review from pbulsink March 13, 2024 00:15
@SCasanova SCasanova mentioned this pull request Mar 13, 2024
17 tasks
@SCasanova SCasanova merged commit 3c7007b into master Mar 13, 2024
18 of 19 checks passed
@SCasanova SCasanova deleted the update_release branch March 13, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants